Bug 30918

Summary:

Web Inspector: Datagrid Rows on Windows not properly aligned

Product:

WebKit

Reporter:

Brian Weinstein <bweinstein>

Component:

Web Inspector (Deprecated)

Assignee:

Brian Weinstein <bweinstein>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aroben, bweinstein, joepeck, pfeldman, rik, timothy

Priority:

Keywords:

PlatformOnly

Version:

528+ (Nightly build)

Hardware:

OS:

Windows 7

Attachments:

Description	Flags
Screen Shot	none
Fix	bweinstein: commit-queue-
Fix with better formatting	bweinstein: commit-queue-
Screenshot w/ line-height: 12px (FIXED)	none
Line-height Fix	timothy: review+, bweinstein: commit-queue-

Brian Weinstein

Reported 2009-10-29 11:24:15 PDT

The size of the text != the size of the rows in the data grids on Windows. On the datagrids I tested, this is true for: Profiling, Local Storage, Session Storage, Cookies.

Attachments
Screen Shot (92.92 KB, image/png) 2009-10-29 11:24 PDT, Brian Weinstein	no flags	Details
Fix (1.85 KB, patch) 2009-10-29 13:35 PDT, Brian Weinstein	bweinstein: commit-queue-	Details Formatted Diff Diff
Fix with better formatting (1.84 KB, patch) 2009-10-29 13:37 PDT, Brian Weinstein	bweinstein: commit-queue-	Details Formatted Diff Diff
Screenshot w/ line-height: 12px (FIXED) (114.60 KB, image/png) 2009-10-29 14:12 PDT, Brian Weinstein	no flags	Details
Line-height Fix (1.11 KB, patch) 2009-10-29 14:18 PDT, Brian Weinstein	timothy: review+ bweinstein: commit-queue-	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Brian Weinstein

Comment 1 2009-10-29 11:24:54 PDT

Created attachment 42116 [details] Screen Shot

Brian Weinstein

Comment 2 2009-10-29 13:35:57 PDT

Created attachment 42131 [details] Fix

Brian Weinstein

Comment 3 2009-10-29 13:37:24 PDT

Created attachment 42133 [details] Fix with better formatting

Timothy Hatcher

Comment 4 2009-10-29 14:02:36 PDT

This patch seems fine. But I think the font looks funny (too small) and the line height is too tall. I bet this can be fixed by making the line-height be a fixed height. Try adding line-height: 12px or 10px (or something) to ".data-grid td".

Brian Weinstein

Comment 5 2009-10-29 14:12:57 PDT

Created attachment 42143 [details] Screenshot w/ line-height: 12px (FIXED)

Brian Weinstein

Comment 6 2009-10-29 14:18:59 PDT

Created attachment 42144 [details] Line-height Fix

Brian Weinstein

Comment 7 2009-10-29 14:25:42 PDT

Landed in r50300.

Note You need to log in before you can comment on or make changes to this bug.