Bug 30890
| Summary: | Windows build: changes in header files do not always trigger correct rebuild. | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Dmitry Titov <dimich> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | aroben, mrowe, sfalken |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | Windows Vista | ||
Dmitry Titov
Example: recent change to JavaScriptCore/wtf/MessageQueue.h broke the Windows build because MessageQueue.h is not included anywhere in JavaScriptCore so the project JavaScriptCore was not build. this project has "post-build step" which make copy of header files to the build directory from where the subsequent WebCore build includes JSC headers. As a result, the stale header of MessageQueue.h was used and build broke.
Changing a cpp file from wtf caused recompile of JavaScriptCore and updated the headers.
I'm not sure what the right fix for this is.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Adam Roben (:aroben)
The right fix is to move all header copying into a Makefile-based project (like JavaScriptCoreGenerated). Makefile-based projects run on every build regardless of whether any .cpp files changed.