Summary: | [chromium] expose a method to access memory usage information in ChromiumBridge | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | anton muhin <antonm> | ||||||||
Component: | WebKit Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, eric, fishd | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
anton muhin
2009-10-27 11:29:00 PDT
Created attachment 41968 [details]
First take
The ChangeLog really doesn't explain at all what this is for, making it difficult to review. Created attachment 42069 [details]
2nd try
Is it enough or still too brief?
Created attachment 42070 [details]
2nd try (for real)
Sorry, too big diff in previous patch
I still don't understand why WebCore needs this information? about:memory is implemented up in Chromium. For the inspector maybe? Except you're never using this function anywhere... I looked at the chromium code review and it was no more clear there what this is for. There isn't a code.google.com issue mentioned there as far as I can tell. Comment on attachment 42070 [details] 2nd try (for real) Clearing flags on attachment: 42070 Committed r50283: <http://trac.webkit.org/changeset/50283> All reviewed patches have been landed. Closing bug. (In reply to comment #6) > I looked at the chromium code review and it was no more clear there what this > is for. There isn't a code.google.com issue mentioned there as far as I can > tell. Eric, sorry I didn't explain it in more details. I need to access info about memory used to force V8's GC when the usage is too high (details are more involved, if you're curious I could cc you on CLs to follow). |