Bug 30816 – [GTK] Failing test fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-in-zoom-and-scroll.html

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Alejandro G. Castro]

The result of this test added in the patch solving the bug 30689 does not work:

--- layout-test-results/fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-in-zoom-and-scroll-expected.txt	2009-10-27 03:22:05.414649015 -0700
+++ layout-test-results/fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-in-zoom-and-scroll-actual.txt	2009-10-27 03:22:05.414649015 -0700
@@ -10,8 +10,8 @@
 Success
 Success
 Success
+Failure, actual: 82; expected: 93
 Success
+Failure, actual: 15; expected: 19
 Success
-Success
-Success
-Success
+Failure, actual: 53; expected: 64

[Xiaomei Ji]

Created attachment 84811 [details]
layout test

The test fails in chromium and qt as well.
Patch to make the test cross-platform.

[Xiaomei Ji]

Comment on attachment 84811 [details]
layout test

Ah, I run it in Mac and chromium-mac. I should run in chromium-linux. Seems that the test for elementFromPoint() is not correct in chromium-linux.

[Xiaomei Ji]

Created attachment 84827 [details]
layout test

[Martin Robinson]

Comment on attachment 84827 [details]
layout test

View in context: https://bugs.webkit.org/attachment.cgi?id=84827&action=review

I tested this change locally and the test is now passing on GTK+. Thanks for the cleanup!

> LayoutTests/fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-in-zoom-and-scroll.html:13
> +    var expectedOffset = 29;

Might want to leave a comment here explaining where 29 comes from.

> LayoutTests/fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-in-zoom-and-scroll.html:16
> +    function check(message, event)

I recommend naming this function something a bit more descriptive.

> LayoutTests/fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-in-zoom-and-scroll.html:18
> +        var range =document.caretRangeFromPoint(event.clientX, event.clientY);

Missing a space after the equal sign here.

[Xiaomei Ji]

Committed r80492: <http://trac.webkit.org/changeset/80492>