Summary: | [GTK] Failing test fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-in-zoom-and-scroll.html | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alejandro G. Castro <alex> | ||||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | xji | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | Linux | ||||||||
Attachments: |
|
Description
Alejandro G. Castro
2009-10-27 06:24:56 PDT
Created attachment 84811 [details]
layout test
The test fails in chromium and qt as well.
Patch to make the test cross-platform.
Comment on attachment 84811 [details]
layout test
Ah, I run it in Mac and chromium-mac. I should run in chromium-linux. Seems that the test for elementFromPoint() is not correct in chromium-linux.
Created attachment 84827 [details]
layout test
Comment on attachment 84827 [details] layout test View in context: https://bugs.webkit.org/attachment.cgi?id=84827&action=review I tested this change locally and the test is now passing on GTK+. Thanks for the cleanup! > LayoutTests/fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-in-zoom-and-scroll.html:13 > + var expectedOffset = 29; Might want to leave a comment here explaining where 29 comes from. > LayoutTests/fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-in-zoom-and-scroll.html:16 > + function check(message, event) I recommend naming this function something a bit more descriptive. > LayoutTests/fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-in-zoom-and-scroll.html:18 > + var range =document.caretRangeFromPoint(event.clientX, event.clientY); Missing a space after the equal sign here. Committed r80492: <http://trac.webkit.org/changeset/80492> |