Bug 30810

Summary:

bugzilla-tool rollout should require a reason

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ddkilzer, mrowe

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	abarth: review+

Description Eric Seidel (no email) 2009-10-27 02:11:11 PDT

bugzilla-tool rollout should prompt for "why?"

It's useful to include "why" we are rolling out a change in the ChangeLog.  bugzilla-tool rollout should prompt for such and include it in the ChangeLog.

Comment 1 Eric Seidel (no email) 2009-12-29 13:40:42 PST

@Adam: Shouldn't this be super-easy now with the "EditChangeLogStep" already built?  And there is a "Show them a diff to confirm" step now too, no?

Comment 2 Eric Seidel (no email) 2010-01-04 21:16:29 PST

I'm just making a reason required.  It's now a command line argument.  I've also added a EditChangeLog and ConfirmDiff steps.

Comment 3 Eric Seidel (no email) 2010-01-04 21:20:22 PST

Created attachment 45860 [details]
Patch

Comment 4 Adam Barth 2010-01-04 21:24:16 PST

Comment on attachment 45860 [details]
Patch

Okiedokes

Comment 5 Eric Seidel (no email) 2010-01-04 21:33:40 PST

Committed r52785: <http://trac.webkit.org/changeset/52785>