Summary: | Add MessageQueue::removeWithPredicate to remove certain tasks without pulling them from the queue. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dmitry Titov <dimich> | ||||
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ap, levin | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.5 | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 30612 | ||||||
Attachments: |
|
Description
Dmitry Titov
2009-10-26 21:07:52 PDT
Created attachment 42047 [details]
Proposed patch.
Comment on attachment 42047 [details] Proposed patch. Just a few nits. Please fix and submit. > diff --git a/JavaScriptCore/wtf/MessageQueue.h b/JavaScriptCore/wtf/MessageQueue.h > + void removeWithPredicate(Predicate&); Consider using "removeIf" instead of "removeWithPredicate" (It is similar in naming to the findIf method on Deque). > + inline void MessageQueue<DataType>::removeWithPredicate(Predicate& predicate) > + { > + MutexLocker lock(m_mutex); > + DequeConstIterator<DataType> found = m_queue.end(); > + while ((found = m_queue.findIf(predicate)) != m_queue.end()) { > + m_queue.remove(found); ASSERT(0); Please remove "ASSERT(0);" > diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog > + (WebCore::SameDatabasePredicate::SameDatabasePredicate): Added predicate that flags the tasks belonging to specified database. Consider: to "a" specified database. > + (WebCore::DatabaseThread::unscheduleDatabaseTasks): changed to use new removeWithPredicate method. Consider: use "the" new removeWithPredicate Fixed all and landed: http://trac.webkit.org/changeset/50247 |