Bug 30798

Summary: REGRESSION (r48687): www.myuhc.com appears blank.
Product: WebKit Reporter: Brady Eidson <beidson>
Component: Page LoadingAssignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P1    
Version: 528+ (Nightly build)   
Hardware: All   
OS: OS X 10.5   
URL: http://myuhc.com
Attachments:
Description Flags
Notify all descendants, not just child frames. darin: review+, beidson: commit-queue-

Brady Eidson
Reported 2009-10-26 16:53:39 PDT
Pages with frames nested more than 1 level deep from the main frame that also have redirects at those deep frames were broken by r48687. This is because child frames now care that *ALL* of their ancestors have finished loading, instead of just their direct parents. But frames don't tell all of their descendants they finished, only their direct children. The fix is to have frames tell all of their descendants when they finish loading.
Attachments
Notify all descendants, not just child frames. (deleted)
2009-10-26 17:12 PDT, Brady Eidson 		darin: review+
beidson: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2009-10-26 17:12:28 PDT
Created attachment 41916 [details] Notify all descendants, not just child frames.
Darin Adler
Comment 2 2009-10-26 17:15:38 PDT
Comment on attachment 41916 [details] Notify all descendants, not just child frames. I would like the test better if it documented success better. The most helpful text in the test is in meta-redirect-to-notify-done.html and that text does not display. In the grandparent it would be good to say a word or two about what a successful result looks like.
Brady Eidson
Comment 3 2009-10-26 17:20:12 PDT
Committed r50116. http://trac.webkit.org/changeset/50116
Note You need to log in before you can comment on or make changes to this bug.