|Summary:||webkit-patch needs an open-bugs command|
|Product:||WebKit||Reporter:||Eric Seidel (no email) <eric>|
|Component:||Tools / Tests||Assignee:||Nobody <webkit-unassigned>|
|Severity:||Normal||CC:||abarth, commit-queue, ddkilzer, levin|
|Version:||528+ (Nightly build)|
|OS:||OS X 10.5|
Description Eric Seidel (no email) 2009-10-26 15:38:52 PDT
Comment 1 Adam Barth 2009-10-27 08:52:38 PDT
I think the windows equivalent is "start"
Comment 2 Eric Seidel (no email) 2010-01-19 16:48:58 PST
Should probably actually be an "open-bugs" command and work like Radar's nifty text field that you can paste any text into and it will find things looking like bug numbers and open them. :)
Comment 3 Eric Seidel (no email) 2010-01-26 13:55:21 PST
Created attachment 47446 [details] Patch
Comment 4 Darin Adler 2010-01-26 15:29:10 PST
Comment on attachment 47446 [details] Patch rs=me I didn't carefully study all the code, but I did read it over. Let me know if I should not review this type of patch in future.
Comment 5 Eric Seidel (no email) 2010-01-26 15:39:19 PST
Not at all. :) More exposure of Darin to python is a good thing. :) This was just a rubber-stamp patch anyway. The only comments I expected to hear were "this would be nice as a stand-alone command" which I agree with... we just need to fix stand-alone commands to work again.
Comment 6 WebKit Commit Bot 2010-01-27 05:01:09 PST
Comment on attachment 47446 [details] Patch Clearing flags on attachment: 47446 Committed r53925: <http://trac.webkit.org/changeset/53925>
Comment 7 WebKit Commit Bot 2010-01-27 05:01:16 PST
All reviewed patches have been landed. Closing bug.
Comment 8 Adam Barth 2010-01-27 23:41:05 PST
I like log("MOCK: user.open_url: %s" % url). That's a nice innovation in our testing infrastructure.
Comment 9 Eric Seidel (no email) 2010-01-27 23:54:31 PST
I actually thought it was slightly lame, to depend on logging... instead of raw mock calls, but this eemed easier. :)