Summary: | webkit-patch needs an open-bugs command | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, commit-queue, ddkilzer, levin | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Eric Seidel (no email)
2009-10-26 15:38:52 PDT
I think the windows equivalent is "start" Should probably actually be an "open-bugs" command and work like Radar's nifty text field that you can paste any text into and it will find things looking like bug numbers and open them. :) Created attachment 47446 [details]
Patch
Comment on attachment 47446 [details]
Patch
rs=me
I didn't carefully study all the code, but I did read it over. Let me know if I should not review this type of patch in future.
Not at all. :) More exposure of Darin to python is a good thing. :) This was just a rubber-stamp patch anyway. The only comments I expected to hear were "this would be nice as a stand-alone command" which I agree with... we just need to fix stand-alone commands to work again. Comment on attachment 47446 [details] Patch Clearing flags on attachment: 47446 Committed r53925: <http://trac.webkit.org/changeset/53925> All reviewed patches have been landed. Closing bug. I like log("MOCK: user.open_url: %s" % url). That's a nice innovation in our testing infrastructure. I actually thought it was slightly lame, to depend on logging... instead of raw mock calls, but this eemed easier. :) |