Bug 30793 - webkit-patch needs an open-bugs command
Summary: webkit-patch needs an open-bugs command
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2009-10-26 15:38 PDT by Eric Seidel (no email)
Modified: 2010-01-27 23:54 PST (History)
4 users (show)

See Also:

Patch (12.65 KB, patch)
2010-01-26 13:55 PST, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2009-10-26 15:38:52 PDT
bugzilla-tool needs an open-bug command

It could also just be a stand-alone "open-bug" command.

1.  If passed a bug number, call "open" with the right URL, or whatever the right platform equivalent of "open" is.
2.  If not passed a bug number, grab the bug url from the ChangeLog diff (if any)?

I would find this useful, maybe others would too.
Comment 1 Adam Barth 2009-10-27 08:52:38 PDT
I think the windows equivalent is "start"
Comment 2 Eric Seidel (no email) 2010-01-19 16:48:58 PST
Should probably actually be an "open-bugs" command and work like Radar's nifty text field that you can paste any text into and it will find things looking like bug numbers and open them. :)
Comment 3 Eric Seidel (no email) 2010-01-26 13:55:21 PST
Created attachment 47446 [details]
Comment 4 Darin Adler 2010-01-26 15:29:10 PST
Comment on attachment 47446 [details]


I didn't carefully study all the code, but I did read it over. Let me know if I should not review this type of patch in future.
Comment 5 Eric Seidel (no email) 2010-01-26 15:39:19 PST
Not at all. :)  More exposure of Darin to python is a good thing. :)

This was just a rubber-stamp patch anyway.  The only comments I expected to hear were "this would be nice as a stand-alone command" which I agree with... we just need to fix stand-alone commands to work again.
Comment 6 WebKit Commit Bot 2010-01-27 05:01:09 PST
Comment on attachment 47446 [details]

Clearing flags on attachment: 47446

Committed r53925: <http://trac.webkit.org/changeset/53925>
Comment 7 WebKit Commit Bot 2010-01-27 05:01:16 PST
All reviewed patches have been landed.  Closing bug.
Comment 8 Adam Barth 2010-01-27 23:41:05 PST
I like log("MOCK: user.open_url: %s" % url).  That's a nice innovation in our testing infrastructure.
Comment 9 Eric Seidel (no email) 2010-01-27 23:54:31 PST
I actually thought it was slightly lame, to depend on logging... instead of raw mock calls, but this eemed easier. :)