Bug 307928
| Summary: | Remove empty #if/#endif blocks regressed by recent protected*() cleanup | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> |
| Component: | WebKit Misc. | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | EasyFix, InRadar, Regression |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 306206, 306264 | ||
| Bug Blocks: | |||
David Kilzer (:ddkilzer)
Recent commits that removed protected*() getter functions left behind empty preprocessor conditional blocks that should be cleaned up.
Empty blocks found:
- Source/WebKit/UIProcess/WebPageProxyInternals.h: `ENABLE(WINDOW_PROXY_PROPERTY_ACCESS_NOTIFICATION)`
- Source/WebKit/UIProcess/Network/NetworkProcessProxy.h: `ENABLE(LEGACY_CUSTOM_PROTOCOL_MANAGER)`
- Source/WebKit/UIProcess/WebPageProxy.cpp: `PLATFORM(IOS_FAMILY) && ENABLE(DEVICE_ORIENTATION)`
- Source/WebKit/UIProcess/WebPageProxy.h: `PLATFORM(IOS_FAMILY) && ENABLE(DEVICE_ORIENTATION)`
These empty blocks were created when the last code between the preprocessor directives was removed but the directives themselves were left in place.
Regression commits:
- Bug 306206 (306184@main): WebPageProxy.cpp, WebPageProxy.h
- Bug 306264 (306257@main): WebPageProxyInternals.h, NetworkProcessProxy.h
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/170409330>
David Kilzer (:ddkilzer)
Pull request: https://github.com/WebKit/WebKit/pull/58742
EWS
Committed 307605@main (f5922987b579): <https://commits.webkit.org/307605@main>
Reviewed commits have been landed. Closing PR #58742 and removing active labels.