Bug 30785

Summary:

Rename TimelineItems to TimelineRecords and update all references.

Product:

WebKit

Reporter:

Kelly Norton <knorton>

Component:

Web Inspector (Deprecated)

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eric, pfeldman, timothy

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Renames everything.	none
Renamed to TimelineRecordEntry	none

Kelly Norton

Reported 2009-10-26 12:48:04 PDT

Need to do a renaming pass in InspectorTimelineAgent, InspectorFrontend, TimelineAgent.js to favor "record" over "item"

Attachments
Renames everything. (36.57 KB, patch) 2009-10-26 14:29 PDT, Kelly Norton	no flags	Details Formatted Diff Diff
Renamed to TimelineRecordEntry (36.61 KB, patch) 2009-10-26 15:38 PDT, Kelly Norton	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Kelly Norton

Comment 1 2009-10-26 14:29:55 PDT

Created attachment 41899 [details] Renames everything.

Timothy Hatcher

Comment 2 2009-10-26 14:34:25 PDT

Comment on attachment 41899 [details] Renames everything. Should RecordEntry be TimelineRecord? (Like TimelineRecordType.) RecordEntry just sounds funny.

Kelly Norton

Comment 3 2009-10-26 14:37:37 PDT

(In reply to comment #2) > (From update of attachment 41899 [details]) > Should RecordEntry be TimelineRecord? (Like TimelineRecordType.) RecordEntry > just sounds funny. Probably, I used the convent of calling them Records inside of InspectorTimelineAgent and TimelineRecords elsewhere. New patch coming.

Kelly Norton

Comment 4 2009-10-26 15:38:56 PDT

Created attachment 41907 [details] Renamed to TimelineRecordEntry

WebKit Commit Bot

Comment 5 2009-10-26 16:12:06 PDT

Comment on attachment 41907 [details] Renamed to TimelineRecordEntry Rejecting patch 41907 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 11520 test cases. svg/css/getComputedStyle-basic.xhtml -> failed Exiting early after 1 failures. 9845 tests run. 320.40s total testing time 9844 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 6 test cases (<1%) had stderr output

Pavel Feldman

Comment 6 2009-10-26 16:15:47 PDT

Comment on attachment 41907 [details] Renamed to TimelineRecordEntry Flaky test?

Eric Seidel (no email)

Comment 7 2009-10-26 16:25:04 PDT

Sorry. The bots are just way behind. bug 30098

WebKit Commit Bot

Comment 8 2009-10-26 20:24:13 PDT

Comment on attachment 41907 [details] Renamed to TimelineRecordEntry Clearing flags on attachment: 41907 Committed r50125: <http://trac.webkit.org/changeset/50125>

WebKit Commit Bot

Comment 9 2009-10-26 20:24:17 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.