Bug 30779

Summary: [Qt] Make QWebPagePrivate's (QWidget) view to be a QWeakPointer
Product: WebKit Reporter: Antonio Gomes <tonikitoo>
Component: WebKit QtAssignee: Antonio Gomes <tonikitoo>
Status: RESOLVED FIXED    
Severity: Normal CC: ariya.hidayat, hausmann, vestbo, zecke
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
(committed in r50142) patch 0.1
none
(committed in r50209) patch 0.2 none

Antonio Gomes
Reported 2009-10-26 09:39:01 PDT
No one is deleting it explicitly, so it can lead to dangling pointers. Making it a qweakpointer would get us safier. patch coming ...
Attachments
(committed in r50142) patch 0.1 (10.20 KB, patch)
2009-10-26 09:40 PDT, Antonio Gomes 		no flags
DetailsFormatted DiffDiff
(committed in r50209) patch 0.2 (1.71 KB, patch)
2009-10-27 14:12 PDT, Antonio Gomes 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antonio Gomes
Comment 1 2009-10-26 09:40:09 PDT
Created attachment 41872 [details] (committed in r50142) patch 0.1
Antonio Gomes
Comment 2 2009-10-27 06:46:58 PDT
commit in r50142 thx for reviewing
Antonio Gomes
Comment 3 2009-10-27 14:12:04 PDT
Created attachment 41984 [details] (committed in r50209) patch 0.2 Patch updated what documentation says: for qweakpointer's tracking qobjects use data() not toStringRef().data() http://doc.trolltech.com/4.6-snapshot/qweakpointer.html#tracking-qobject it fixes current Qt-DRT crash
Antonio Gomes
Comment 4 2009-10-27 14:12:39 PDT
reopening to track the pending commit
Holger Freyther
Comment 5 2009-10-28 00:41:46 PDT
Hmm... bad inconsistency and the "other context" is pretty vague too.. I would r=+ if you agree to do a spelling fix before landing the commit.
Holger Freyther
Comment 6 2009-10-28 00:46:20 PDT
okay and the problem toStringRef it must be toStrongRef
Antonio Gomes
Comment 7 2009-10-28 03:24:58 PDT
patch 2 landed in r50209 thx zecke
Note You need to log in before you can comment on or make changes to this bug.