| Summary: | [Qt] Conditional jump on uninitialized variable in QWebSettings | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jakob Truelsen <antialize> | ||||||
| Component: | WebKit Qt | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED INVALID | ||||||||
| Severity: | Major | CC: | benjamin, eric, jturcotte, kenneth | ||||||
| Priority: | P2 | Keywords: | Qt | ||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | PC | ||||||||
| OS: | OS X 10.5 | ||||||||
| Bug Depends on: | 29042 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
|
Description
Jakob Truelsen
2009-10-25 04:39:31 PDT
Created attachment 41818 [details]
Fix unitialize valiabels
Fix uninitialized variabels and give global variabels default values (copied from within webkit)
Comment on attachment 41818 [details]
Fix unitialize valiabels
Why change the defaults? That's not documented in the Changelog.
Also, are these the only defaults that constructor misses? What about defaultTextEncoding?
The default was changed to bring it in line with other variables, such as defaultTextEncoding, but I can not do that if you like. The defaultTextEncoding is a QString, so naturally it cannot be uninitialized. There wight have been other floates, ints, or bools that where unititialized, but I do not think so. At least valgrind did not complain about this. Created attachment 43053 [details]
Fix uninitialized vars and ABI issues
Duplicate of bug #31058 Please ensure that both bugs are closed when the issue is resolved. Comment on attachment 43053 [details]
Fix uninitialized vars and ABI issues
No test.
The patch that introduced this change was reverted, so this should be part of a newer version of that patch, when reintroduced. Marking invalid. |