Bug 30755

Summary:

[Qt] Conditional jump on uninitialized variable in QWebSettings

Product:

WebKit

Reporter:

Jakob Truelsen <antialize>

Component:

WebKit Qt

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED INVALID

Severity:

Major

CC:

benjamin, eric, jturcotte, kenneth

Priority:

Keywords:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Bug Depends on:

29042

Bug Blocks:

Attachments:

Description	Flags
Fix unitialize valiabels	eric: review-
Fix uninitialized vars and ABI issues	abarth: review-

Jakob Truelsen

Reported 2009-10-25 04:39:31 PDT

When I made the patch in https://bugs.webkit.org/show_bug.cgi?id=29042. I did not fully understand the QWebSettings class. The result is that calling apply will result in a jump on an uninitialized variable.

Attachments
Fix unitialize valiabels (1.48 KB, patch) 2009-10-25 04:44 PDT, Jakob Truelsen	eric: review-	Details Formatted Diff Diff
Fix uninitialized vars and ABI issues (4.24 KB, patch) 2009-11-12 03:14 PST, Jakob Truelsen	abarth: review-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Jakob Truelsen

Comment 1 2009-10-25 04:44:08 PDT

Created attachment 41818 [details] Fix unitialize valiabels Fix uninitialized variabels and give global variabels default values (copied from within webkit)

Eric Seidel (no email)

Comment 2 2009-10-26 14:50:31 PDT

Comment on attachment 41818 [details] Fix unitialize valiabels Why change the defaults? That's not documented in the Changelog. Also, are these the only defaults that constructor misses? What about defaultTextEncoding?

Jakob Truelsen

Comment 3 2009-10-26 23:55:17 PDT

The default was changed to bring it in line with other variables, such as defaultTextEncoding, but I can not do that if you like. The defaultTextEncoding is a QString, so naturally it cannot be uninitialized. There wight have been other floates, ints, or bools that where unititialized, but I do not think so. At least valgrind did not complain about this.

Jakob Truelsen

Comment 4 2009-11-12 03:14:40 PST

Created attachment 43053 [details] Fix uninitialized vars and ABI issues

Jocelyn Turcotte

Comment 5 2009-11-12 06:23:02 PST

Duplicate of bug #31058 Please ensure that both bugs are closed when the issue is resolved.

Adam Barth

Comment 6 2009-11-12 20:47:54 PST

Comment on attachment 43053 [details] Fix uninitialized vars and ABI issues No test.

Kenneth Rohde Christiansen

Comment 7 2009-11-13 04:55:57 PST

The patch that introduced this change was reverted, so this should be part of a newer version of that patch, when reintroduced. Marking invalid.

Note You need to log in before you can comment on or make changes to this bug.