Bug 30751

Summary: HTMLOptionsCollection should not inherit from HTMLCollection (according to HTML5)
Product: WebKit Reporter: Sam Weinig <sam>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED INVALID    
Severity: Normal CC: bweinstein, dglazkov, joepeck
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
patch none

Sam Weinig
Reported 2009-10-24 17:27:21 PDT
HTMLOptionsCollection should not inherit from HTMLCollection (according to HTML5). Right now, only our JS bindings have this issue.
Attachments
patch (30.44 KB, patch)
2009-10-24 17:36 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2009-10-24 17:36:23 PDT
Created attachment 41800 [details] patch
mitz
Comment 2 2009-10-24 18:04:24 PDT
Comment on attachment 41800 [details] patch r=me assuming you add the new .h file to other project files and address the comments from IRC.
Sam Weinig
Comment 3 2009-10-24 19:45:26 PDT
Fixed in r50037.
Brian Weinstein
Comment 4 2009-10-25 00:23:46 PDT
This broke the Windows build, so rolled out in r50040. Build error: http://build.webkit.org/builders/Windows%20Release%20%28Build%29/builds/6258/steps/compile-webkit/logs/stdio
Joseph Pecoraro
Comment 5 2009-10-25 08:58:52 PDT
Hmm, this bug was made 10/24 but it must have been a few hours later that the following was committed to HTML5 Make collections inherit from HTMLCollection Fixing http://www.w3.org/Bugs/Public/show_bug.cgi?id=8035 Commit Diff: http://html5.org/tools/web-apps-tracker?from=4322&to=4323 > - <pre class="idl">interface <dfn>HTMLOptionsCollection</dfn> { - attribute unsigned long <span title="dom-HTMLOptionsCollection-length">length</span>; > + <pre class="idl">interface <dfn>HTMLOptionsCollection</dfn> : <span>HTMLCollection</span> {
Sam Weinig
Comment 6 2009-10-25 09:14:19 PDT
(In reply to comment #5) > Hmm, this bug was made 10/24 but it must have been a few hours later that the > following was committed to HTML5 > > Make collections inherit from HTMLCollection > Fixing http://www.w3.org/Bugs/Public/show_bug.cgi?id=8035 > > Commit Diff: > http://html5.org/tools/web-apps-tracker?from=4322&to=4323 > > > - <pre class="idl">interface <dfn>HTMLOptionsCollection</dfn> { > - attribute unsigned long <span > title="dom-HTMLOptionsCollection-length">length</span>; > > + <pre class="idl">interface <dfn>HTMLOptionsCollection</dfn> : <span>HTMLCollection</span> { Wow. That is quite upsetting. Fun times.
Eric Seidel (no email)
Comment 7 2009-10-26 12:01:39 PDT
Comment on attachment 41800 [details] patch Clearing mitz's r+ on this patch since it was rolled out. (This was it's not in the to-be-committed list).
Sam Weinig
Comment 8 2009-10-26 13:05:39 PDT
I rolled out this change in r50087.
Alexey Proskuryakov
Comment 9 2009-12-29 02:38:13 PST
*** Bug 32997 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.