Summary: | HTMLOptionsCollection should not inherit from HTMLCollection (according to HTML5) | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||
Component: | DOM | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED INVALID | ||||||
Severity: | Normal | CC: | bweinstein, dglazkov, joepeck | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Sam Weinig
2009-10-24 17:27:21 PDT
Created attachment 41800 [details]
patch
Comment on attachment 41800 [details]
patch
r=me assuming you add the new .h file to other project files and address the comments from IRC.
This broke the Windows build, so rolled out in r50040. Build error: http://build.webkit.org/builders/Windows%20Release%20%28Build%29/builds/6258/steps/compile-webkit/logs/stdio Hmm, this bug was made 10/24 but it must have been a few hours later that the following was committed to HTML5 Make collections inherit from HTMLCollection Fixing http://www.w3.org/Bugs/Public/show_bug.cgi?id=8035 Commit Diff: http://html5.org/tools/web-apps-tracker?from=4322&to=4323 > - <pre class="idl">interface <dfn>HTMLOptionsCollection</dfn> { - attribute unsigned long <span title="dom-HTMLOptionsCollection-length">length</span>; > + <pre class="idl">interface <dfn>HTMLOptionsCollection</dfn> : <span>HTMLCollection</span> { (In reply to comment #5) > Hmm, this bug was made 10/24 but it must have been a few hours later that the > following was committed to HTML5 > > Make collections inherit from HTMLCollection > Fixing http://www.w3.org/Bugs/Public/show_bug.cgi?id=8035 > > Commit Diff: > http://html5.org/tools/web-apps-tracker?from=4322&to=4323 > > > - <pre class="idl">interface <dfn>HTMLOptionsCollection</dfn> { > - attribute unsigned long <span > title="dom-HTMLOptionsCollection-length">length</span>; > > + <pre class="idl">interface <dfn>HTMLOptionsCollection</dfn> : <span>HTMLCollection</span> { Wow. That is quite upsetting. Fun times. Comment on attachment 41800 [details]
patch
Clearing mitz's r+ on this patch since it was rolled out. (This was it's not in the to-be-committed list).
|