Summary: | Missing images at 350.org due to wrong URLs | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | mitz | ||||||||
Component: | DOM | Assignee: | mitz | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | darin | ||||||||
Priority: | P2 | Keywords: | HasReduction | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
URL: | http://www.350.org/ | ||||||||||
Attachments: |
|
Description
mitz
2009-10-24 11:58:06 PDT
Created attachment 41788 [details]
Reduction
Both Firefox and Opera print 'true' for the reduction. Created attachment 41793 [details]
Use deprecatedParseURL() in getURLAttribute
Created attachment 41795 [details]
Use deprecatedParseURL() in getURLAttribute()
Fixed in <http://trac.webkit.org/changeset/50029>. If stripping whitespace is what's needed, then I wish we would do just that rather than deprecatedParseURL, but I suppose it's best to be consistent :-( (In reply to comment #6) > If stripping whitespace is what's needed, then I wish we would do just that > rather than deprecatedParseURL, but I suppose it's best to be consistent :-( I didn’t know exactly what king of cleanup was needed, so I just went with what the loader and the Objective-C bindings were already doing. deprecatedParseURL() is almost certainly wrong, and I would have added a FIXME in all three call sites if it weren’t already named “deprecated”. |