Bug 30745

Summary: [v8] implement ReturnsNew IDL hint for V8 code generator
Product: WebKit Reporter: anton muhin <antonm>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
First take
abarth: review+, abarth: commit-queue-
"No new tests" line removed none

Description anton muhin 2009-10-24 11:52:09 PDT
In IDL some methods has ReturnsNew tag which guarantees that results of such methods are fresh objects.  It allows to skip checks for presence of the wrapper for the object.
Comment 1 anton muhin 2009-10-24 11:55:32 PDT
Created attachment 41786 [details]
First take
Comment 2 Adam Barth 2009-10-24 12:00:53 PDT
Comment on attachment 41786 [details]
First take

This looks fine.

+        No new tests. (OOPS!)

This line will prevent the commit-queue from landing the patch, however.
Comment 3 anton muhin 2009-10-24 15:04:30 PDT
Created attachment 41798 [details]
"No new tests" line removed
Comment 4 anton muhin 2009-10-24 15:05:42 PDT
(In reply to comment #2)
> (From update of attachment 41786 [details])
> This looks fine.
> 
> +        No new tests. (OOPS!)
> 
> This line will prevent the commit-queue from landing the patch, however.

Thanks a lot for review, Adam.  "No new tests" line removed in the new patch.
Comment 5 WebKit Commit Bot 2009-10-24 15:40:25 PDT
Comment on attachment 41798 [details]
"No new tests" line removed

Clearing flags on attachment: 41798

Committed r50030: <http://trac.webkit.org/changeset/50030>
Comment 6 WebKit Commit Bot 2009-10-24 15:40:28 PDT
All reviewed patches have been landed.  Closing bug.