Bug 30742

Summary:

Web Inspector: REGRESSION: Can't resize the Element's sidebar

Product:

WebKit

Reporter:

Timothy Hatcher <timothy>

Component:

Web Inspector (Deprecated)

Assignee:

Timothy Hatcher <timothy>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aroben, bweinstein, joepeck, pfeldman, rik, timothy

Priority:

Keywords:

Regression

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Proposed Patch	pfeldman: review+

Description Timothy Hatcher 2009-10-24 09:47:18 PDT

The Element's sidebar can't be resized anymore. It seems the resize div is floating in the middle of the elements tree somewhere.

Maybe this was caused by the sidebar migration to Panel?

Comment 1 Timothy Hatcher 2009-10-24 11:08:21 PDT

Created attachment 41784 [details]
Proposed Patch

Comment 2 Joseph Pecoraro 2009-10-24 11:45:55 PDT

Hehe, the patch itself looks good to me. The only thing that caught my eye was something that wasn't changed, but showed up in the context:

> +  updateMainViewWidth: function(width)
>    {
>      // Should be implemented by ancestors.
>    }

"ancestors" means ↑ (up). Really this should be the children (sub "classes") that implement it.

Comment 3 Pavel Feldman 2009-10-24 15:54:16 PDT

Comment on attachment 41784 [details]
Proposed Patch

Nice. I have nearly identical patch locally.

Comment 4 Pavel Feldman 2009-10-24 16:06:16 PDT

> "ancestors" means ↑ (up). Really this should be the children (sub "classes")

Oops. Should be subclasses.

Comment 5 Timothy Hatcher 2009-10-24 20:01:30 PDT

Committed r50033: <http://trac.webkit.org/changeset/50033>