Bug 30720

Summary:

Web Inspector: pull basic sidebar implementation into the Panel.

Product:

WebKit

Reporter:

Pavel Feldman <pfeldman>

Component:

Web Inspector (Deprecated)

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

timothy

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
patch	timothy: review+

Pavel Feldman

Reported 2009-10-23 11:12:30 PDT

Currently there is a bunch of copypaste in Profiles and Storage. There is almost the same piece in resources, but it scrolls differently...

Attachments
patch (10.73 KB, patch) 2009-10-23 11:13 PDT, Pavel Feldman	timothy: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Pavel Feldman

Comment 1 2009-10-23 11:13:35 PDT

Created attachment 41735 [details] patch

Timothy Hatcher

Comment 2 2009-10-23 11:21:10 PDT

Comment on attachment 41735 [details] patch Nice! Maybe setMainViewWidth is a better name than setCenterViewWidth?

Pavel Feldman

Comment 3 2009-10-23 13:48:23 PDT

Landing with comments addressed Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/Panel.js M WebCore/inspector/front-end/ProfilesPanel.js M WebCore/inspector/front-end/StoragePanel.js Committed r49997

Note You need to log in before you can comment on or make changes to this bug.