Bug 30713

Summary: Disable ReadWriteLock on platforms using pthreads but which do not support pthread_rwlock
Product: WebKit Reporter: Steve Block <steveblock>
Component: JavaScriptCoreAssignee: Steve Block <steveblock>
Status: RESOLVED FIXED    
Severity: Normal CC: benm, commit-queue, hyatt, steveblock
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Attachments:
Description Flags
Patch 1 for Bug 30713 none

Steve Block
Reported 2009-10-23 06:38:28 PDT
ReadWriteLock is currently used only on SnowLeopard. See http://trac.webkit.org/changeset/44651. It is therefore implemented only on platforms using pthreads. However, some platforms that use pthreads (eg Android) do not support pthread_rwlock. For these platforms, ReadWriteLock should be disabled.
Attachments
Patch 1 for Bug 30713 (3.22 KB, patch)
2009-10-23 06:45 PDT, Steve Block 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Steve Block
Comment 1 2009-10-23 06:45:01 PDT
Created attachment 41723 [details] Patch 1 for Bug 30713
Eric Seidel (no email)
Comment 2 2009-10-23 11:42:46 PDT
Comment on attachment 41723 [details] Patch 1 for Bug 30713 This looks sane to me, but whoever added the ReadWriteLock stuff should really review/comment here.
Mark Rowe (bdash)
Comment 3 2009-10-24 00:54:10 PDT
It’s not used anywhere. I suspect it was added for a short-lived experiment, and that we can now rip it out completely.
Darin Adler
Comment 4 2009-10-25 16:18:28 PDT
Comment on attachment 41723 [details] Patch 1 for Bug 30713 Seems OK. I'm not sure it's good to have all these cases, this one included, where the type PlatformReadWriteLock defined to be void*. If we're going to omit ReadWriteLock, then I suggest we do that in the header too rather than compiling a useless ReadWriteLock. What's more, I can't find any code using ReadWriteLock anywhere in the WebKit source code nor in Safari's source code. It looks like Hyatt added this class but never started using it. This patch is fine, but I think we could also consider dropping this unused code. I see that Mark Rowe said the same thing in his recent comment.
Steve Block
Comment 5 2009-10-26 03:26:23 PDT
> What's more, I can't find any code using ReadWriteLock anywhere in the WebKit > source code nor in Safari's source code. I wasn't sure if Hyatt was still working on the code that makes use of this class. I'll commit this patch, but if Hyatt can confirm that the class isn't needed, I'll happily send a patch to remove it completely.
WebKit Commit Bot
Comment 6 2009-10-26 03:47:04 PDT
Comment on attachment 41723 [details] Patch 1 for Bug 30713 Clearing flags on attachment: 41723 Committed r50052: <http://trac.webkit.org/changeset/50052>
WebKit Commit Bot
Comment 7 2009-10-26 03:47:11 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.