Bug 30692

Summary:

Incorrect pixel result for test svg-as-background-6

Product:

WebKit

Reporter:

Victor Wang <victorw>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eric, krit

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Proposed Patch	none

Description Victor Wang 2009-10-22 14:56:43 PDT

The old pixel results of svg-as-background-6 is incorrect because of the wrong SVG Masking offset calculation. The issue was fixed by patch: http://trac.webkit.org/changeset/49598
Needs to update the expected pixel result for this test.

Comment 1 Victor Wang 2009-10-22 15:00:34 PDT

Created attachment 41687 [details]
Proposed Patch

Comment 2 Eric Seidel (no email) 2009-10-23 11:39:53 PDT

Comment on attachment 41687 [details]
Proposed Patch

We really should change this test not to use red as a backup color.  Red generally means fail, but I believe this SVG is supposed to be transparent so red is correct.

Comment 3 Victor Wang 2009-10-23 11:53:04 PDT

Eric,
Thanks for reviewing this, could you add the patch to commit-queue? Thanks!

Comment 4 Eric Seidel (no email) 2009-10-23 12:08:04 PDT

Comment on attachment 41687 [details]
Proposed Patch

Sure thing.  You can always set commit-queue? on your patches to request that folks add them to the commit-queue for you.

Comment 5 WebKit Commit Bot 2009-10-23 13:06:07 PDT

Comment on attachment 41687 [details]
Proposed Patch

Clearing flags on attachment: 41687

Committed r49991: <http://trac.webkit.org/changeset/49991>

Comment 6 WebKit Commit Bot 2009-10-23 13:06:12 PDT

All reviewed patches have been landed.  Closing bug.