Bug 30684

Summary:

Makes page reload optional when enabling resource monitoring in InspectorController

Product:

WebKit

Reporter:

jaimeyap

Component:

Web Inspector (Deprecated)

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, pfeldman, timothy

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Makes page reload optional when enabling resource monitoring in InspectorController	timothy: review-
re-adds patch that includes link to this bug in ChangeLog	timothy: review-
removes tabs from ChangeLog	none

jaimeyap

Reported 2009-10-22 11:44:14 PDT

Created attachment 41673 [details] Makes page reload optional when enabling resource monitoring in InspectorController This patch makes page reload optional when enabling resource monitoring in InspectorController. It is really useful for tools to be able to selectively turn on resource tracking without forcing the page to reload, potentially throwing away application state that is relevant to what you were intended to monitor. This patch does not change the default behavior (inspecting and activating resource monitoring still triggers page load).

Attachments
Makes page reload optional when enabling resource monitoring in InspectorController (2.37 KB, patch) 2009-10-22 11:44 PDT, jaimeyap	timothy: review-	Details Formatted Diff Diff
re-adds patch that includes link to this bug in ChangeLog (2.43 KB, patch) 2009-10-22 12:01 PDT, jaimeyap	timothy: review-	Details Formatted Diff Diff
removes tabs from ChangeLog (2.44 KB, patch) 2009-10-22 12:16 PDT, jaimeyap	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Timothy Hatcher

Comment 1 2009-10-22 11:57:02 PDT

Comment on attachment 41673 [details] Makes page reload optional when enabling resource monitoring in InspectorController How is this used? r- since there are tabs in the ChangeLog. Next time, mark patches for review in Bugzilla to get a review.

jaimeyap

Comment 2 2009-10-22 12:01:28 PDT

Created attachment 41675 [details] re-adds patch that includes link to this bug in ChangeLog

Timothy Hatcher

Comment 3 2009-10-22 12:03:16 PDT

Comment on attachment 41675 [details] re-adds patch that includes link to this bug in ChangeLog > + InspectorController. It leaves the default behavior as performing the reload. > + Reload is an optional param so callsites do not have to change. > + > + Bug link: https://bugs.webkit.org/show_bug.cgi?id=30684 Tabs should be spaces. No need for "Bug link: " prefix.

jaimeyap

Comment 4 2009-10-22 12:16:43 PDT

Created attachment 41676 [details] removes tabs from ChangeLog

Pavel Feldman

Comment 5 2009-10-22 12:20:13 PDT

This might make us end up in a weird state. Why do you need this? If that is for timeline, I'd suggest adding timeline events into the timeline agent and log there ignoring the enabledResourcesTracking flag. This way you decouple from resources.

Pavel Feldman

Comment 6 2009-10-22 12:42:05 PDT

Comment on attachment 41676 [details] removes tabs from ChangeLog I have no better solution to that yet...

Timothy Hatcher

Comment 7 2009-10-22 13:12:08 PDT

(In reply to comment #5) > This might make us end up in a weird state. Why do you need this? If that is > for timeline, I'd suggest adding timeline events into the timeline agent and > log there ignoring the enabledResourcesTracking flag. This way you decouple > from resources. I agree. If Timeline wants to show resources they should be tracked seperatly (and likely with less info.)

WebKit Commit Bot

Comment 8 2009-10-22 13:19:52 PDT

Comment on attachment 41676 [details] removes tabs from ChangeLog Clearing flags on attachment: 41676 Committed r49954: <http://trac.webkit.org/changeset/49954>

WebKit Commit Bot

Comment 9 2009-10-22 13:19:58 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.