Bug 30682

Summary:

[Qt] Add Print shortcut to QtLauncher

Product:

WebKit

Reporter:

Girish Ramakrishnan <girish>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Keywords:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[Qt] Add Print Shortcut to QtLauncher	none

Girish Ramakrishnan

Reported 2009-10-22 11:31:02 PDT

Add shortcut.

Attachments
[Qt] Add Print Shortcut to QtLauncher (1.22 KB, patch) 2009-10-22 12:20 PDT, Girish Ramakrishnan	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Girish Ramakrishnan

Comment 1 2009-10-22 12:20:51 PDT

Created attachment 41677 [details] [Qt] Add Print Shortcut to QtLauncher WebKit/qt/ChangeLog | 11 +++++++++++ WebKit/qt/QtLauncher/main.cpp | 2 +- 2 files changed, 12 insertions(+), 1 deletions(-)

Eric Seidel (no email)

Comment 2 2009-10-22 12:43:59 PDT

Comment on attachment 41677 [details] [Qt] Add Print Shortcut to QtLauncher Looks like this is new as of 4.2. I'm not sure what version of Qt the QtWebKit folks are trying to target. http://doc.trolltech.com/4.4/qkeysequence.html#StandardKey-enum That said, this looks fine as far as I can tell. This is a debugging tool after all. :)

WebKit Commit Bot

Comment 3 2009-10-22 13:10:19 PDT

Comment on attachment 41677 [details] [Qt] Add Print Shortcut to QtLauncher Clearing flags on attachment: 41677 Committed r49953: <http://trac.webkit.org/changeset/49953>

WebKit Commit Bot

Comment 4 2009-10-22 13:10:25 PDT

All reviewed patches have been landed. Closing bug.

Girish Ramakrishnan

Comment 5 2009-10-22 19:44:06 PDT

(In reply to comment #2) > (From update of attachment 41677 [details]) > Looks like this is new as of 4.2. I'm not sure what version of Qt the QtWebKit > folks are trying to target. > http://doc.trolltech.com/4.4/qkeysequence.html#StandardKey-enum > > That said, this looks fine as far as I can tell. This is a debugging tool > after all. :) We target >= Qt 4.4. Thanks :)

Note You need to log in before you can comment on or make changes to this bug.