Summary: | Inspector injects _inspectorCommandLineAPI into global object when opened | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Martin Häcker <spamfaenger> | ||||||
Component: | Web Inspector (Deprecated) | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | aroben, commit-queue, joepeck, keishi, pfeldman, rik, timothy | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Mac (Intel) | ||||||||
OS: | OS X 10.6 | ||||||||
Attachments: |
|
You may need to reload the example a few times for the problem to show up. Drat. With the Inspector open that is. Created attachment 41709 [details]
proposed patch
Moved _inspectorCommandLineAPI to console. _inspectorCommandLineAPI
I guess will be safer.
Comment on attachment 41709 [details]
proposed patch
Rejecting patch 41709 from commit-queue.
Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1
Running build-dumprendertree
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 11506 test cases.
fast/media/mq-transform-02.html -> failed
Exiting early after 1 failures. 7441 tests run.
139.35s total testing time
7440 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
3 test cases (<1%) had stderr output
Comment on attachment 41709 [details]
proposed patch
Sorry about the commit-queue trouble. Should work fine now.
Comment on attachment 41709 [details] proposed patch Clearing flags on attachment: 41709 Committed r49988: <http://trac.webkit.org/changeset/49988> All reviewed patches have been landed. Closing bug. |
Created attachment 41659 [details] Showcase of the problem This is of course disturbing my unit tests which check if I accidentally pollute the global object with any new keys. I guess this is not intentional, but instead because there is a var statement missing in front o f a variable declaration. This is a regression as Safari 4 does not behave like this.