Bug 30674 – Failed on test case: http://www.w3.org/Style/CSS/Test/CSS2.1/current/html4/t0511-c21-pseud-link-02-e.htm

• Component: CSS
• Status: RESOLVED INVALID

[Chang Shu]

Run test case on any WebKit browsers:
http://www.w3.org/Style/CSS/Test/CSS2.1/current/html4/t0511-c21-pseud-link-02-e.htm

Expected result: the color of the link should be green
Actual result: the color of the link is red

[Chang Shu]

Created attachment 42222 [details]
fix patch

This patch does not have test case yet as I just want to make sure the code change is fine.

[Darin Adler]

Comment on attachment 42222 [details]
fix patch

This only patches the Qt-specific code path, not the normal platform-independent one. It’s also not the best practice to post a patch knowingly leaving out the test you plan to make. It creates more work for reviewers who have to review it twice even if there’s nothing wrong with it. It’s better engineering to write the test before the bug fix -- you need to make sure it fails without the code change.

[Chang Shu]

(In reply to comment #2)
> (From update of attachment 42222 [details])
> This only patches the Qt-specific code path, not the normal
> platform-independent one. It’s also not the best practice to post a patch
> knowingly leaving out the test you plan to make. It creates more work for
> reviewers who have to review it twice even if there’s nothing wrong with it.
> It’s better engineering to write the test before the bug fix -- you need to
> make sure it fails without the code change.

Thanks very much for the comments. I will take care of the test cases soon.

[Chang Shu]

It turns out that none of the major browsers: IE, Firefox, Safari, supports this. As a result, I have to cancel the review process. If nobody rejects, I will mark this bug as resolved. Is this the right procedure?