Bug 30657

Summary: video-played.js uses too short of a timeout
Product: WebKit Reporter: Andrew Scherkus <scherkus>
Component: MediaAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Round 1 none

Andrew Scherkus
Reported 2009-10-21 18:52:04 PDT
We have issues running LayoutTest/media/video-played-*.html family of tests because the error timeout is too aggressive. Since it's based on reaching 10 call counts, tests that use a short delay will result in a tight window to meet the deadline. For example: playForMillisecs(100) -> 100 x 10 = 1 second deadline playForMillisecs(30) -> 30 x 10 = 300 millisecond deadline I propose letting call counts go wild while measuring the actual time elapsed.
Attachments
Round 1 (2.21 KB, patch)
2009-10-21 18:55 PDT, Andrew Scherkus 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andrew Scherkus
Comment 1 2009-10-21 18:55:12 PDT
Created attachment 41628 [details] Round 1 No change to expectations required. Passing on WebKit Mac.
Eric Carlson
Comment 2 2009-10-22 06:27:57 PDT
Comment on attachment 41628 [details] Round 1 Nice change, thanks! r=me
WebKit Commit Bot
Comment 3 2009-10-22 08:53:19 PDT
Comment on attachment 41628 [details] Round 1 Clearing flags on attachment: 41628 Committed r49941: <http://trac.webkit.org/changeset/49941>
WebKit Commit Bot
Comment 4 2009-10-22 08:53:23 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.