Bug 30657

Summary:

video-played.js uses too short of a timeout

Product:

WebKit

Reporter:

Andrew Scherkus <scherkus>

Component:

Media

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eric.carlson

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Round 1	none

Description Andrew Scherkus 2009-10-21 18:52:04 PDT

We have issues running LayoutTest/media/video-played-*.html family of tests because the error timeout is too aggressive.

Since it's based on reaching 10 call counts, tests that use a short delay will result in a tight window to meet the deadline.  For example:
playForMillisecs(100) -> 100 x 10 = 1 second deadline
playForMillisecs(30) -> 30 x 10 = 300 millisecond deadline

I propose letting call counts go wild while measuring the actual time elapsed.

Comment 1 Andrew Scherkus 2009-10-21 18:55:12 PDT

Created attachment 41628 [details]
Round 1

No change to expectations required.  Passing on WebKit Mac.

Comment 2 Eric Carlson 2009-10-22 06:27:57 PDT

Comment on attachment 41628 [details]
Round 1

Nice change, thanks!

r=me

Comment 3 WebKit Commit Bot 2009-10-22 08:53:19 PDT

Comment on attachment 41628 [details]
Round 1

Clearing flags on attachment: 41628

Committed r49941: <http://trac.webkit.org/changeset/49941>

Comment 4 WebKit Commit Bot 2009-10-22 08:53:23 PDT

All reviewed patches have been landed.  Closing bug.