Bug 30632

Summary:

bugzilla-tool's "patch failed to download an apply" error should give more information

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, commit-queue, ddkilzer, levin

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Make svn-apply failures log to the bug	none
Updated with test case	none

Eric Seidel (no email)

Reported 2009-10-21 10:22:00 PDT

bugzilla-tool's "patch failed to download an apply" error should give more information https://bugs.webkit.org/show_bug.cgi?id=30435#c9 is one of numerous examples. Will post a patch shortly.

Attachments
Make svn-apply failures log to the bug (2.29 KB, patch) 2009-10-21 11:23 PDT, Eric Seidel (no email)	no flags	Details Formatted Diff Diff
Updated with test case (6.54 KB, patch) 2009-10-21 16:26 PDT, Eric Seidel (no email)	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Eric Seidel (no email)

Comment 1 2009-10-21 11:23:19 PDT

Created attachment 41589 [details] Make svn-apply failures log to the bug

Adam Barth

Comment 2 2009-10-21 13:42:05 PDT

Comment on attachment 41589 [details] Make svn-apply failures log to the bug Unit test?

Eric Seidel (no email)

Comment 3 2009-10-21 16:26:41 PDT

Created attachment 41618 [details] Updated with test case

Adam Barth

Comment 4 2009-10-21 23:06:53 PDT

Comment on attachment 41618 [details] Updated with test case Not what I was expecting you to test, but I'll take it.

WebKit Commit Bot

Comment 5 2009-10-21 23:20:34 PDT

Comment on attachment 41618 [details] Updated with test case Clearing flags on attachment: 41618 Committed r49931: <http://trac.webkit.org/changeset/49931>

WebKit Commit Bot

Comment 6 2009-10-21 23:20:39 PDT

All reviewed patches have been landed. Closing bug.

Eric Seidel (no email)

Comment 7 2009-10-21 23:49:56 PDT

Morbid curiosity: what were you expecting me to test?

Adam Barth

Comment 8 2009-10-22 00:03:28 PDT

(In reply to comment #7) > Morbid curiosity: what were you expecting me to test? Mostly that bugzilla-tool's "patch failed to download an apply" error should give more information.

Note You need to log in before you can comment on or make changes to this bug.