Bug 30630
| Summary: | [Qt] QWebElement::removeChildren() should be QWebElement::removeAllChildren() | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Benjamin Poulain <benjamin> |
| Component: | WebKit Qt | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | benjamin, kenneth, vestbo |
| Priority: | P2 | Keywords: | Qt |
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
| Bug Depends on: | |||
| Bug Blocks: | 29843 | ||
Benjamin Poulain
The usual prefix to remove the all the elements of a collection is "removeAll", not "remove".
E.g.
QWebDatabase::removeAllDatabases()
QUrl::removeAllQueryItems().
QWebElement::removeChildren() should be QWebElement::removeAllChildren() for consistency.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Kenneth Rohde Christiansen
I'm fully OK with that.
Tor Arne Vestbø
Me too
Kenneth Rohde Christiansen
Landed in 50147