Summary: | [Haiku] Issue with accented letters | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Maxime Simon <simon.maxime> | ||||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, leavengood | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | Other | ||||||||
Attachments: |
|
Comment on attachment 41563 [details]
Patch
This needs a ChangeLog with explanation of what this is doing.
Created attachment 41600 [details]
Patch v1
Comment on attachment 41600 [details]
Patch v1
Have you considered using the UTF8 Encoder of WebCore instead of your custom conversion routine? "hack" somehow indicates that this is an interim solution?
Comment on attachment 41600 [details] Patch v1 Clearing flags on attachment: 41600 Committed r49937: <http://trac.webkit.org/changeset/49937> All reviewed patches have been landed. Closing bug. (In reply to comment #3) > (From update of attachment 41600 [details]) > Have you considered using the UTF8 Encoder of WebCore instead of your custom > conversion routine? "hack" somehow indicates that this is an interim solution? Actually we use this "hack" function in two different places of our code. But indeed I should investigate on using UTF8 Encoder. Thanks. |
Created attachment 41563 [details] Patch Accented letters have a twice to big width (problem with unicode). The function SimpleFontData::platformWidthForGlyph(Glyph) is wrongly implemented. So I reused charUnicodeToUTF8HACK(unsigned short, char*) from WebCore/platform/graphics/haiku/FontHaiku.cpp . Regards, Maxime