Bug 30629

Summary: [Haiku] Issue with accented letters
Product: WebKit Reporter: Maxime Simon <simon.maxime>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, leavengood
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Other   
Attachments:
Description Flags
Patch
none
Patch v1 none

Maxime Simon
Reported 2009-10-21 07:16:12 PDT
Created attachment 41563 [details] Patch Accented letters have a twice to big width (problem with unicode). The function SimpleFontData::platformWidthForGlyph(Glyph) is wrongly implemented. So I reused charUnicodeToUTF8HACK(unsigned short, char*) from WebCore/platform/graphics/haiku/FontHaiku.cpp . Regards, Maxime
Attachments
Patch (1.13 KB, patch)
2009-10-21 07:16 PDT, Maxime Simon 		no flags
DetailsFormatted DiffDiff
Patch v1 (1.77 KB, patch)
2009-10-21 12:26 PDT, Maxime Simon 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2009-10-21 10:28:44 PDT
Comment on attachment 41563 [details] Patch This needs a ChangeLog with explanation of what this is doing.
Maxime Simon
Comment 2 2009-10-21 12:26:06 PDT
Created attachment 41600 [details] Patch v1
Holger Freyther
Comment 3 2009-10-22 04:44:02 PDT
Comment on attachment 41600 [details] Patch v1 Have you considered using the UTF8 Encoder of WebCore instead of your custom conversion routine? "hack" somehow indicates that this is an interim solution?
WebKit Commit Bot
Comment 4 2009-10-22 04:52:59 PDT
Comment on attachment 41600 [details] Patch v1 Clearing flags on attachment: 41600 Committed r49937: <http://trac.webkit.org/changeset/49937>
WebKit Commit Bot
Comment 5 2009-10-22 04:53:02 PDT
All reviewed patches have been landed. Closing bug.
Maxime Simon
Comment 6 2009-10-22 05:06:05 PDT
(In reply to comment #3) > (From update of attachment 41600 [details]) > Have you considered using the UTF8 Encoder of WebCore instead of your custom > conversion routine? "hack" somehow indicates that this is an interim solution? Actually we use this "hack" function in two different places of our code. But indeed I should investigate on using UTF8 Encoder. Thanks.
Note You need to log in before you can comment on or make changes to this bug.