|Summary:||[Haiku] Issue with accented letters|
|Product:||WebKit||Reporter:||Maxime Simon <simon.maxime>|
|Component:||WebCore Misc.||Assignee:||Nobody <webkit-unassigned>|
|Version:||528+ (Nightly build)|
Description Maxime Simon 2009-10-21 07:16:12 PDT
Created attachment 41563 [details] Patch Accented letters have a twice to big width (problem with unicode). The function SimpleFontData::platformWidthForGlyph(Glyph) is wrongly implemented. So I reused charUnicodeToUTF8HACK(unsigned short, char*) from WebCore/platform/graphics/haiku/FontHaiku.cpp . Regards, Maxime
Comment 1 Eric Seidel (no email) 2009-10-21 10:28:44 PDT
Comment on attachment 41563 [details] Patch This needs a ChangeLog with explanation of what this is doing.
Comment 3 Holger Freyther 2009-10-22 04:44:02 PDT
Comment on attachment 41600 [details] Patch v1 Have you considered using the UTF8 Encoder of WebCore instead of your custom conversion routine? "hack" somehow indicates that this is an interim solution?
Comment 4 WebKit Commit Bot 2009-10-22 04:52:59 PDT
Comment on attachment 41600 [details] Patch v1 Clearing flags on attachment: 41600 Committed r49937: <http://trac.webkit.org/changeset/49937>
Comment 5 WebKit Commit Bot 2009-10-22 04:53:02 PDT
All reviewed patches have been landed. Closing bug.
Comment 6 Maxime Simon 2009-10-22 05:06:05 PDT
(In reply to comment #3) > (From update of attachment 41600 [details]) > Have you considered using the UTF8 Encoder of WebCore instead of your custom > conversion routine? "hack" somehow indicates that this is an interim solution? Actually we use this "hack" function in two different places of our code. But indeed I should investigate on using UTF8 Encoder. Thanks.