Bug 30611

Summary:

Fix the crash when a node not in a document receives dispatchEvent.

Product:

WebKit

Reporter:

Dmitry Titov <dimich>

Component:

WebCore JavaScript

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Proposed patch.	darin: review+, dimich: commit-queue-

Dmitry Titov

Reported 2009-10-20 17:36:06 PDT

The node that doesn't have a document (easy to repro with documentType node which is just created) crashes while trying to dispatchEvent. FireFox in similar scenario simply treats dispatchEvent() as noop. We should do the same. Patch is coming.

Attachments
Proposed patch. (3.59 KB, patch) 2009-10-20 17:52 PDT, Dmitry Titov	darin: review+ dimich: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Dmitry Titov

Comment 1 2009-10-20 17:52:55 PDT

Created attachment 41539 [details] Proposed patch.

Darin Adler

Comment 2 2009-10-20 23:53:47 PDT

Comment on attachment 41539 [details] Proposed patch. r=me

Dmitry Titov

Comment 3 2009-10-21 11:35:08 PDT

Landed: http://trac.webkit.org/changeset/49911

Note You need to log in before you can comment on or make changes to this bug.