| Summary: | Fix click-focus-anchor test | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Victor Wang <victorw> | ||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | adele, commit-queue, eric | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | PC | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Victor Wang
2009-10-20 17:21:07 PDT
Created attachment 41538 [details]
Proposed Patch
Is there any effect any any form of the expected results? It fails on chromium test because the current events more like drag not click. The expectation results are fine. Comment on attachment 41538 [details]
Proposed Patch
Looks fine. Seems Chromium's test_shell may have more issues like this. Seeting cq+ since Victor is not a committer.
Comment on attachment 41538 [details] Proposed Patch Rejecting patch 41538 from commit-queue. Failed to run "['git', 'svn', 'rebase']" exit_code: 1 RA layer request failed: PROPFIND request failed on '/repository/webkit': PROPFIND of '/repository/webkit': could not connect to server (http://svn.webkit.org) at /usr/local/libexec/git-core//git-svn line 1909 Eric, Looks like the commit bot failed to land this patch, could you check? Thanks, Victor Comment on attachment 41538 [details]
Proposed Patch
I'm not sure what would cause that. I'm also not sure if the commit-queue should spin in that instance or fail like it did here. Let's just add it back to the queue.
Comment on attachment 41538 [details] Proposed Patch Clearing flags on attachment: 41538 Committed r49914: <http://trac.webkit.org/changeset/49914> All reviewed patches have been landed. Closing bug. |