Bug 30591

Summary: Make Chromium Mac pasteboard code flow like other platforms
Product: WebKit Reporter: Avi Drissman <avi>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: atwilson, eric, fishd
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
Patch eric: review+, avi: commit-queue-

Avi Drissman
Reported 2009-10-20 12:36:40 PDT
Right now the Chromium Mac pasteboard code is unimplemented. This is the WebCore side of the patch (the Chromium side is http://codereview.chromium.org/308001).
Attachments
Patch (2.47 KB, patch)
2009-10-20 12:38 PDT, Avi Drissman 		eric: review+
avi: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Avi Drissman
Comment 1 2009-10-20 12:38:14 PDT
Created attachment 41517 [details] Patch
Eric Seidel (no email)
Comment 2 2009-10-20 23:16:05 PDT
Comment on attachment 41517 [details] Patch LGTM. Darin should see this go by, I'll CC him. Seems a little odd for ChromiumBridge.h to include ImageSource.h, but OK.
Avi Drissman
Comment 3 2009-10-21 12:02:22 PDT
I tried to mark the patch as Darin's for review but there was no edit box. Is that something new?
Eric Seidel (no email)
Comment 4 2009-10-21 12:16:03 PDT
You should subscribe to webkit-dev if you aren't already. :) https://lists.webkit.org/pipermail/webkit-dev/2009-October/010091.html
Darin Fisher (:fishd, Google)
Comment 5 2009-10-21 16:41:18 PDT
r=me
Andrew Wilson
Comment 6 2009-10-22 10:49:42 PDT
landed as r49946
Note You need to log in before you can comment on or make changes to this bug.