Bug 30589

Summary:

[GTK] Failing media/video-played-reset.html

Product:

WebKit

Reporter:

Xan Lopez <xan.lopez>

Component:

Media

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
proposed patch	none
unskip fixed test	none

Description Xan Lopez 2009-10-20 11:59:32 PDT

Seems to jump between failing and timing out.

Comment 1 Philippe Normand 2009-11-02 09:51:00 PST

Created attachment 42321 [details]
proposed patch

Our GStreamer-based player does seeking by sending a seek event to playbin2. Current position is not immediately updated so we can end up in a state where currentTime() is called while a seek is in progress. The patch adds a new private attribute in the player class, used to cache the seek time position during seeking so currentTime reports the correct position.

Comment 2 Philippe Normand 2009-11-02 09:51:58 PST

Created attachment 42322 [details]
unskip fixed test

Comment 3 Jan Alonzo 2009-11-02 11:15:22 PST

Comment on attachment 42321 [details]
proposed patch

r=me.

Comment 4 WebKit Commit Bot 2009-11-02 11:34:24 PST

Comment on attachment 42321 [details]
proposed patch

Clearing flags on attachment: 42321

Committed r50424: <http://trac.webkit.org/changeset/50424>

Comment 5 WebKit Commit Bot 2009-11-02 12:14:42 PST

Comment on attachment 42322 [details]
unskip fixed test

Clearing flags on attachment: 42322

Committed r50425: <http://trac.webkit.org/changeset/50425>

Comment 6 WebKit Commit Bot 2009-11-02 12:14:45 PST

All reviewed patches have been landed.  Closing bug.