Bug 30570

Summary: The op_next_pname should use 4 bytes addressing mode in case of JSValue32
Product: WebKit Reporter: Gabor Loki <loki>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ggaren
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
The op_next_pname should use 4 bytes addressing mode in case of JSValue32 none

Gabor Loki
Reported 2009-10-20 06:57:32 PDT
The changeset 49734 introduced a bug in JSValue32. In emit_op_next_pname function the addressing mode to access key @i should be use 4 bytes instead of 8 bytes. I seems like a copy-paste error.
Attachments
The op_next_pname should use 4 bytes addressing mode in case of JSValue32 (1.58 KB, patch)
2009-10-20 06:58 PDT, Gabor Loki 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gabor Loki
Comment 1 2009-10-20 06:58:26 PDT
Created attachment 41505 [details] The op_next_pname should use 4 bytes addressing mode in case of JSValue32
Geoffrey Garen
Comment 2 2009-10-20 11:27:29 PDT
Comment on attachment 41505 [details] The op_next_pname should use 4 bytes addressing mode in case of JSValue32 Oops! Thanks.
WebKit Commit Bot
Comment 3 2009-10-20 11:41:48 PDT
Comment on attachment 41505 [details] The op_next_pname should use 4 bytes addressing mode in case of JSValue32 Clearing flags on attachment: 41505 Committed r49874: <http://trac.webkit.org/changeset/49874>
WebKit Commit Bot
Comment 4 2009-10-20 11:41:52 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.