Bug 305520
| Summary: | Digital Credentials: Fix safer C++ checker warnings in WKDigitalCredentialsPicker.mm | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Marcos Caceres <marcosc> |
| Component: | New Bugs | Assignee: | Marcos Caceres <marcosc> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Marcos Caceres
WebKit's safer C++ checker flagged several memory safety issues in WKDigitalCredentialsPicker.mm related to improper smart pointer usage when calling non-trivial member functions.
The safer C++ checker identified four violations of WebKit's safer C++ guidelines:
* fetchRawRequestsWithCompletionHandler:line 242 - "Uncounted call argument for a raw pointer/reference parameter"
* handleNSError:line 413 - "Uncounted call argument for a raw pointer/reference parameter"
* presentationAnchor:line 236 - "Unretained call argument for a raw pointer/reference parameter"
* mapRequestAuthentications:line 192 - "Unretained raw pointer or reference not provably backed by a RetainPtr"
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/168182333>
Marcos Caceres
Pull request: https://github.com/WebKit/WebKit/pull/56599
EWS
Committed 305642@main (b8dfd19251f6): <https://commits.webkit.org/305642@main>
Reviewed commits have been landed. Closing PR #56599 and removing active labels.