Bug 305435
| Summary: | [libpas] Hold lock during retag-on-scavenge tag-setting for bitfit heaps | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Marcus Plutowski <marcus_plutowski> |
| Component: | bmalloc | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | ggaren, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Marcus Plutowski
rdar://165772439
Previously, we were doing the tag-writes outside of the mutex; this is unsafe since it also takes place strictly after the slot is returned to use, so it's possible for the memory to be re-allocated while we're tagging it.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Marcus Plutowski
The feature is not currently enabled, so when the above goes in we can turn it on at the same time.
Marcus Plutowski
Pull request: https://github.com/WebKit/WebKit/pull/56594
EWS
Committed 305977@main (9705a6950cd2): <https://commits.webkit.org/305977@main>
Reviewed commits have been landed. Closing PR #56594 and removing active labels.