| Summary: | Replace QWebFrame::clipContentsToViewport with better API | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kenneth Rohde Christiansen <kenneth> | ||||||
| Component: | WebKit Qt | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | hausmann, rich | ||||||
| Priority: | P2 | Keywords: | Qt | ||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | PC | ||||||||
| OS: | All | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 29843 | ||||||||
| Attachments: |
|
||||||||
Follow up patch will remove the clipContentsToViewport property Comment on attachment 41444 [details]
First part of the clipContentsToViewport fix (introduce paint method, deprecate render)
Let's discuss this further before landing
Created attachment 41454 [details]
Second version incorporating feedback from IRC
Might be worth considering making the numbers for the enum a bit bigger so that if you later want to add intermediate layers they can still have an id that reflects the stacking order. eg. 0x10, 0x20 etc. instead of 0x01, 0x02. Landed in 49850 Comment on attachment 41454 [details]
Second version incorporating feedback from IRC
Supposedly this patch was landed, so removing r?.
|
Created attachment 41444 [details] First part of the clipContentsToViewport fix (introduce paint method, deprecate render) We had a quick round of API review with Matthias here at the DevDays and came up with the following suggestions for changes: * QWebFrame::clipContentsToViewport: 1) Remove the property 2) Deprecate QWebFrame::render() 3) Introduce QWebFrame::paint(QWebFrame::PaintOptions opts = QWebFrame::AllElements), so that one can for eaxmple call frame->paint(QWebFrame::Contents); frame->paint(QWebFrame::Contents | QWebFrame::ScrollBars);