Bug 305233
| Summary: | JSC::getCallDataInline has fragile include dependency on unified sources | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Vassili Bykov <v_bykov> |
| Component: | JavaScriptCore | Assignee: | Vassili Bykov <v_bykov> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | berto, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Vassili Bykov
The inline function JSC::getCallDataInline() in JSObjectInlines.h calls JSFunction::getCallDataInline() from JSFunctionInlines.h. Because of that, it requires JSFunctionInlines.h to be included at that point. However, there is no explicit include to guarantee this. The code only builds because unified sources happen to bundle translation units in a favorable order. This is fragile, and the build broke for me with in an old toolchain on Sonoma.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/167876001>
Vassili Bykov
Pull request: https://github.com/WebKit/WebKit/pull/56374
EWS
Committed 305548@main (cda948675446): <https://commits.webkit.org/305548@main>
Reviewed commits have been landed. Closing PR #56374 and removing active labels.
Alberto Garcia
*** Bug 305387 has been marked as a duplicate of this bug. ***