Bug 30513

Summary: All HTML5 media element events should be regular events
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed patch
simon.fraser: review-
Updated patch to call renderer->updateFromElement when posting a 'progress' event. simon.fraser: review+

Eric Carlson
Reported 2009-10-19 08:38:07 PDT
r4133 changed all progress events to regular events the "loaded" field doesn't make sense for a media engine that doesn't keep data buffered, and because we don't have a concept of "loaded" any more. http://html5.org/tools/web-apps-tracker?from=4132&to=4133
Attachments
Proposed patch (13.19 KB, patch)
2009-11-30 09:51 PST, Eric Carlson 		simon.fraser: review-
DetailsFormatted DiffDiff
Updated patch to call renderer->updateFromElement when posting a 'progress' event. (13.50 KB, patch)
2009-11-30 10:17 PST, Eric Carlson 		simon.fraser: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2009-11-30 09:51:27 PST
Created attachment 44026 [details] Proposed patch
Simon Fraser (smfr)
Comment 2 2009-11-30 09:58:11 PST
Comment on attachment 44026 [details] Proposed patch scheduleProgressEvent() used to call updateFromElement(), which I think updated the controller for a progressively downloaded file. I'm not sure what will do that now.
Eric Carlson
Comment 3 2009-11-30 10:17:25 PST
Created attachment 44027 [details] Updated patch to call renderer->updateFromElement when posting a 'progress' event.
Eric Carlson
Comment 4 2009-11-30 13:45:13 PST
http://trac.webkit.org/changeset/51511
Note You need to log in before you can comment on or make changes to this bug.