Bug 305051

Summary: [GTK][WPE] remove dead code from WebPageProxy::activityStateDidChange
Product: WebKit Reporter: Przemyslaw Gorszkowski <pgorszkowski>
Component: New BugsAssignee: Przemyslaw Gorszkowski <pgorszkowski>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Linux   

Przemyslaw Gorszkowski
Reported 2026-01-07 06:07:18 PST
There is #elif, which will never be called: #if PLATFORM(COCOA) || PLATFORM(GTK) || PLATFORM(WPE) bool isNewlyInWindow = !isInWindow() && (mayHaveChanged & ActivityState::IsInWindow) && pageClient->isViewInWindow(); if (dispatchMode == ActivityStateChangeDispatchMode::Immediate || isNewlyInWindow) { dispatchActivityStateChange(); return; } scheduleActivityStateUpdate(); #elif PLATFORM(GTK) || PLATFORM(WPE) UNUSED_PARAM(dispatchMode); scheduleActivityStateUpdate(); #else UNUSED_PARAM(dispatchMode); dispatchActivityStateChange(); #endif
Attachments
Przemyslaw Gorszkowski
Comment 1 2026-01-07 06:14:13 PST
EWS
Comment 2 2026-01-08 02:31:55 PST
Committed 305264@main (521c611f97c4): <https://commits.webkit.org/305264@main> Reviewed commits have been landed. Closing PR #56198 and removing active labels.
Radar WebKit Bug Importer
Comment 3 2026-01-08 02:32:12 PST
Note You need to log in before you can comment on or make changes to this bug.