Bug 305051
| Summary: | [GTK][WPE] remove dead code from WebPageProxy::activityStateDidChange | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Przemyslaw Gorszkowski <pgorszkowski> |
| Component: | New Bugs | Assignee: | Przemyslaw Gorszkowski <pgorszkowski> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Linux | ||
Przemyslaw Gorszkowski
There is #elif, which will never be called:
#if PLATFORM(COCOA) || PLATFORM(GTK) || PLATFORM(WPE)
bool isNewlyInWindow = !isInWindow() && (mayHaveChanged & ActivityState::IsInWindow) && pageClient->isViewInWindow();
if (dispatchMode == ActivityStateChangeDispatchMode::Immediate || isNewlyInWindow) {
dispatchActivityStateChange();
return;
}
scheduleActivityStateUpdate();
#elif PLATFORM(GTK) || PLATFORM(WPE)
UNUSED_PARAM(dispatchMode);
scheduleActivityStateUpdate();
#else
UNUSED_PARAM(dispatchMode);
dispatchActivityStateChange();
#endif
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Przemyslaw Gorszkowski
Pull request: https://github.com/WebKit/WebKit/pull/56198
EWS
Committed 305264@main (521c611f97c4): <https://commits.webkit.org/305264@main>
Reviewed commits have been landed. Closing PR #56198 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/167754312>