Bug 30496

Summary: Web Inspector: make console tests more granular.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: timothy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch timothy: review+, commit-queue: commit-queue-

Pavel Feldman
Reported 2009-10-18 16:33:25 PDT
Split console tests into dir, dirxml, format and log level tests.
Attachments
patch (10.43 KB, patch)
2009-10-18 16:34 PDT, Pavel Feldman 		timothy: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2009-10-18 16:34:32 PDT
Created attachment 41388 [details] patch
Timothy Hatcher
Comment 2 2009-10-18 16:37:44 PDT
Comment on attachment 41388 [details] patch Is function callback(result) somethign we can share between tests?
Pavel Feldman
Comment 3 2009-10-18 17:13:34 PDT
(In reply to comment #2) > (From update of attachment 41388 [details]) > Is function callback(result) somethign we can share between tests? We should be able to do that by means of console-tests.js or something. But given that these tests are supposed to test different things, they could diverge. Fortammer's one is already different...
Timothy Hatcher
Comment 4 2009-10-18 18:38:33 PDT
(In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 41388 [details] [details]) > > Is function callback(result) somethign we can share between tests? > > We should be able to do that by means of console-tests.js or something. But > given that these tests are supposed to test different things, they could > diverge. Fortammer's one is already different... OK
Yong Li
Comment 5 2009-10-19 08:47:05 PDT
Comment on attachment 41388 [details] patch Let commit bot land it
WebKit Commit Bot
Comment 6 2009-10-19 08:48:15 PDT
Comment on attachment 41388 [details] patch Rejecting patch 41388 from commit-queue. Patch https://bugs.webkit.org/attachment.cgi?id=41388 from bug 30496 failed to download and apply.
Pavel Feldman
Comment 7 2009-10-19 09:31:28 PDT
Landed as r49760
Note You need to log in before you can comment on or make changes to this bug.