Bug 30474

Summary: Use _stricmp and _strnicmp instead of deprecated stricmp and strnicmp.
Product: WebKit Reporter: Kwang Yul Seo <skyul>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben, commit-queue, darin, eric, sfalken
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows XP   
Attachments:
Description Flags
Use ISO C++ conformant _stricmp and _strnicmp
none
Update ChangeLog none

Kwang Yul Seo
Reported 2009-10-16 20:50:34 PDT
POSIX function such as stricmp and strnicmp are deprecated beginning in Visual C++ 2005. Use ISO C++ conformant _stricmp and _strnicmp instead in StringExtras.h.
Attachments
Use ISO C++ conformant _stricmp and _strnicmp (1.29 KB, patch)
2009-10-16 20:53 PDT, Kwang Yul Seo 		no flags
DetailsFormatted DiffDiff
Update ChangeLog (1.27 KB, patch)
2009-10-17 00:43 PDT, Kwang Yul Seo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kwang Yul Seo
Comment 1 2009-10-16 20:53:50 PDT
Created attachment 41350 [details] Use ISO C++ conformant _stricmp and _strnicmp
Eric Seidel (no email)
Comment 2 2009-10-16 23:36:32 PDT
darin, arboen or sfalken are likely better reviewers for this than I.
Mark Rowe (bdash)
Comment 3 2009-10-17 00:07:27 PDT
The bug title, ChangeLog, and Visual Studio warning are incredibly misleading. strnicmp is not part of POSIX and _strnicmp is certainly not part part of the ISO C++ standard. They’re both Microsoft extensions. The change itself is probably fine but IMO the ChangeLog should be corrected.
Kwang Yul Seo
Comment 4 2009-10-17 00:41:46 PDT
Change the title.
Kwang Yul Seo
Comment 5 2009-10-17 00:43:37 PDT
Created attachment 41354 [details] Update ChangeLog Update the ChangeLog because stricmp and strnicmp are not POSIX functions but Microsfot extensions.
WebKit Commit Bot
Comment 6 2009-10-18 23:43:51 PDT
Comment on attachment 41354 [details] Update ChangeLog Clearing flags on attachment: 41354 Committed r49765: <http://trac.webkit.org/changeset/49765>
WebKit Commit Bot
Comment 7 2009-10-18 23:43:55 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.