Bug 30472

Summary: EventHandler::eventLoopHandleMouseDragged needs ENABLE(DRAG_SUPPORT) guards
Product: WebKit Reporter: Kwang Yul Seo <skyul>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dbates, eric, oliver
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
ENABLE(DRAG_SUPPORT) guards around EventHandler::eventLoopHandleMouseDragged none

Description Kwang Yul Seo 2009-10-16 20:13:28 PDT 
There are ENABLE(DRAG_SUPPORT) guards around EventHandler::eventLoopHandleMouseDragged in EventHandler.h, but missing in EventHandler.cpp. 

MSVC fails to compile when DRAG_SUPPORT is not enabled.
Comment 1 Kwang Yul Seo 2009-10-16 20:17:29 PDT 
Created attachment 41346 [details]
ENABLE(DRAG_SUPPORT) guards around EventHandler::eventLoopHandleMouseDragged
Comment 2 Eric Seidel (no email) 2009-10-16 23:34:48 PDT 
Comment on attachment 41346 [details]
ENABLE(DRAG_SUPPORT) guards around EventHandler::eventLoopHandleMouseDragged

Makes no sense that that is marked "inline".  But this looks OK.

The latter #endif really should have a comment explaingin which #if its ending.
Comment 3 Eric Seidel (no email) 2009-10-16 23:35:39 PDT 
CCing drag and drop folks so they see this go by.
Comment 4 WebKit Commit Bot 2009-10-17 08:54:32 PDT 
Comment on attachment 41346 [details]
ENABLE(DRAG_SUPPORT) guards around EventHandler::eventLoopHandleMouseDragged

Clearing flags on attachment: 41346

Committed r49742: <http://trac.webkit.org/changeset/49742>
Comment 5 WebKit Commit Bot 2009-10-17 08:54:41 PDT 
All reviewed patches have been landed.  Closing bug.