Bug 30464

Summary:

Remove HTML5 media element 'load' event

Product:

WebKit

Reporter:

Eric Carlson <eric.carlson>

Component:

Media

Assignee:

Eric Carlson <eric.carlson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, eric, ossy, scherkus, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch 1: change layout tests	none
proposed patch	none
Better patch, fix a bogus 'FAIL' log.	sam: review+

Eric Carlson

Reported 2009-10-16 15:02:59 PDT

r4132 removed the 'load' event - http://html5.org/tools/web-apps-tracker?from=4131&to=4132

Attachments
Patch 1: change layout tests (59.49 KB, patch) 2009-10-19 09:21 PDT, Eric Carlson	no flags	Details Formatted Diff Diff
proposed patch (20.09 KB, patch) 2010-07-18 13:42 PDT, Eric Carlson	no flags	Details Formatted Diff Diff
Better patch, fix a bogus 'FAIL' log. (21.75 KB, patch) 2010-07-18 13:55 PDT, Eric Carlson	sam: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Eric Carlson

Comment 1 2009-10-19 09:21:36 PDT

Created attachment 41424 [details] Patch 1: change layout tests

Eric Seidel (no email)

Comment 2 2009-10-19 14:00:50 PDT

Comment on attachment 41424 [details] Patch 1: change layout tests Looks sane enough to me.

Andrew Scherkus

Comment 3 2009-10-19 14:51:02 PDT

Oh boy this is exciting!!! Change looks good.. canplaythrough is analogous to load with the exception that seeking will cause canplaythrough to fire again However I don't see any layout tests that would get confused by this

Eric Carlson

Comment 4 2009-10-26 08:29:15 PDT

First patch submitted, http://trac.webkit.org/changeset/50063

Eric Carlson

Comment 5 2010-07-18 13:42:58 PDT

Created attachment 61910 [details] proposed patch

Eric Carlson

Comment 6 2010-07-18 13:55:16 PDT

Created attachment 61911 [details] Better patch, fix a bogus 'FAIL' log.

Eric Carlson

Comment 7 2010-07-19 13:20:06 PDT

http://trac.webkit.org/changeset/63684

WebKit Review Bot

Comment 8 2010-07-19 13:47:45 PDT

http://trac.webkit.org/changeset/63684 might have broken GTK Linux 32-bit Release and Qt Linux Release

Csaba Osztrogonác

Comment 9 2010-07-19 22:30:23 PDT

(In reply to comment #8) > http://trac.webkit.org/changeset/63684 might have broken GTK Linux 32-bit Release and Qt Linux Release And all Mac bot. :( fast/dom/Window/window-properties-expected.txt files updated in http://trac.webkit.org/changeset/63720

Note You need to log in before you can comment on or make changes to this bug.