Bug 304415
| Summary: | Use NO_UNIQUE_ADDRESS macro instead of [[no_unique_address]] attribute | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Brandon <brandonstewart> |
| Component: | WebCore Misc. | Assignee: | Brandon <brandonstewart> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | ryosei.otaka, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Other | ||
| Hardware: | PC | ||
| OS: | Windows 11 | ||
Brandon
Windows builds with clang-cl fail to recognize [[no_unique_address]]
even when compiling with C++23. WebKit already has a NO_UNIQUE_ADDRESS
macro in Compiler.h that properly detects compiler support for this
attribute and falls back to empty definition when unavailable.
Replace direct use of [[no_unique_address]] with the NO_UNIQUE_ADDRESS
macro in RefCounted base classes to fix Windows builds while maintaining
the attribute on platforms that support it.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/166795977>
Brandon
Pull request: https://github.com/WebKit/WebKit/pull/55633
EWS
Committed 304697@main (62df643698ea): <https://commits.webkit.org/304697@main>
Reviewed commits have been landed. Closing PR #55633 and removing active labels.
ryosei.otaka
*** Bug 304411 has been marked as a duplicate of this bug. ***