Summary: | WebKitTools/Scripts/check-webkit-style incorrect complains about unindented code within namespaces in header files | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | James Robinson <jamesr> | ||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, levin | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
James Robinson
2009-10-15 21:33:21 PDT
Created attachment 41265 [details]
Fixes the script
fyi, I just r+ a fix for the same issue (namespace indentation) that was pretty minimal in scope (https://bugs.webkit.org/show_bug.cgi?id=30426). I still think there is a lot of value on what you did here with some fixes as mentioned above. You can still basically replace the code as you are doing. Ugh. Ignore my previous comment. It was meant for another bug. Comment on attachment 41265 [details] Fixes the script Clearing flags on attachment: 41265 Committed r49669: <http://trac.webkit.org/changeset/49669> All reviewed patches have been landed. Closing bug. |