Bug 30426

Summary: WebKitTools/Scripts/check-webkit-style incorrect complains about unindented code within namespaces in header files
Product: WebKit Reporter: James Robinson <jamesr>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, levin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: OS X 10.5   
Attachments:
Description Flags
Fixes the script none

James Robinson
Reported 2009-10-15 21:33:21 PDT
The WebKit style guide now says that code inside namespaces should not be indented even if it's inside a header file (thank $Deity)! However, check-webkit-style is out of date and still whines about it.
Attachments
Fixes the script (6.48 KB, patch)
2009-10-15 21:39 PDT, James Robinson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2009-10-15 21:39:49 PDT
Created attachment 41265 [details] Fixes the script
David Levin
Comment 2 2009-10-15 21:51:04 PDT
fyi, I just r+ a fix for the same issue (namespace indentation) that was pretty minimal in scope (https://bugs.webkit.org/show_bug.cgi?id=30426). I still think there is a lot of value on what you did here with some fixes as mentioned above. You can still basically replace the code as you are doing.
David Levin
Comment 3 2009-10-15 21:51:33 PDT
Ugh. Ignore my previous comment. It was meant for another bug.
WebKit Commit Bot
Comment 4 2009-10-15 22:03:50 PDT
Comment on attachment 41265 [details] Fixes the script Clearing flags on attachment: 41265 Committed r49669: <http://trac.webkit.org/changeset/49669>
WebKit Commit Bot
Comment 5 2009-10-15 22:03:53 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.