Bug 30410

Summary: Chromium media controls should display a disabled play button when no src
Product: WebKit Reporter: Andrew Scherkus <scherkus>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Severity: Normal CC: commit-queue, eric.carlson, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: OS X 10.5   
Description Flags
Round 1 none

Description Andrew Scherkus 2009-10-15 15:14:19 PDT
Right now we show an enabled play button even if an audio/video element has no valid src.  Bad!!
Comment 1 Andrew Scherkus 2009-10-15 18:16:31 PDT
Created attachment 41257 [details]
Round 1

Nice and easy :D
Comment 2 Eric Seidel (no email) 2009-10-16 13:35:38 PDT
LGTM.  CCing eric so he sees this go by.
Comment 3 Eric Seidel (no email) 2009-10-16 13:35:58 PDT
Comment on attachment 41257 [details]
Round 1

I'm no expert here, but this looks simple and correct.
Comment 4 WebKit Commit Bot 2009-10-16 13:56:58 PDT
Comment on attachment 41257 [details]
Round 1

Clearing flags on attachment: 41257

Committed r49695: <http://trac.webkit.org/changeset/49695>
Comment 5 WebKit Commit Bot 2009-10-16 13:57:02 PDT
All reviewed patches have been landed.  Closing bug.