Bug 30410

Summary:

Chromium media controls should display a disabled play button when no src

Product:

WebKit

Reporter:

Andrew Scherkus <scherkus>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eric.carlson, eric

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

OS X 10.5

Attachments:

Description	Flags
Round 1	none

Andrew Scherkus

Reported 2009-10-15 15:14:19 PDT

Right now we show an enabled play button even if an audio/video element has no valid src. Bad!!

Attachments
Round 1 (1.58 KB, patch) 2009-10-15 18:16 PDT, Andrew Scherkus	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Andrew Scherkus

Comment 1 2009-10-15 18:16:31 PDT

Created attachment 41257 [details] Round 1 Nice and easy :D

Eric Seidel (no email)

Comment 2 2009-10-16 13:35:38 PDT

LGTM. CCing eric so he sees this go by.

Eric Seidel (no email)

Comment 3 2009-10-16 13:35:58 PDT

Comment on attachment 41257 [details] Round 1 I'm no expert here, but this looks simple and correct.

WebKit Commit Bot

Comment 4 2009-10-16 13:56:58 PDT

Comment on attachment 41257 [details] Round 1 Clearing flags on attachment: 41257 Committed r49695: <http://trac.webkit.org/changeset/49695>

WebKit Commit Bot

Comment 5 2009-10-16 13:57:02 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.