Bug 30410 - Chromium media controls should display a disabled play button when no src
Summary: Chromium media controls should display a disabled play button when no src
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-15 15:14 PDT by Andrew Scherkus
Modified: 2009-10-16 13:57 PDT (History)
3 users (show)

See Also:

Attachments
Round 1 (1.58 KB, patch)
2009-10-15 18:16 PDT, Andrew Scherkus 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Scherkus 2009-10-15 15:14:19 PDT 
Right now we show an enabled play button even if an audio/video element has no valid src.  Bad!!
Comment 1 Andrew Scherkus 2009-10-15 18:16:31 PDT 
Created attachment 41257 [details]
Round 1

Nice and easy :D
Comment 2 Eric Seidel (no email) 2009-10-16 13:35:38 PDT 
LGTM.  CCing eric so he sees this go by.
Comment 3 Eric Seidel (no email) 2009-10-16 13:35:58 PDT 
Comment on attachment 41257 [details]
Round 1

I'm no expert here, but this looks simple and correct.
Comment 4 WebKit Commit Bot 2009-10-16 13:56:58 PDT 
Comment on attachment 41257 [details]
Round 1

Clearing flags on attachment: 41257

Committed r49695: <http://trac.webkit.org/changeset/49695>
Comment 5 WebKit Commit Bot 2009-10-16 13:57:02 PDT 
All reviewed patches have been landed.  Closing bug.