Summary: | HTML 5 media elements should set network state to NETWORK_EMPTY if they do not have a source | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andrew Scherkus <scherkus> | ||||||||||
Component: | Media | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | commit-queue, eric.carlson, eric | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | All | ||||||||||||
OS: | OS X 10.5 | ||||||||||||
Attachments: |
|
Description
Andrew Scherkus
2009-10-15 14:36:00 PDT
Created attachment 41246 [details]
Round 1
Comment on attachment 41246 [details]
Round 1
Digging around some more I found more bugs... I'll keep working on this patch.
Created attachment 41255 [details]
Round 2
Few things (as mentioned in the patch):
- Having no source is defined as a null src attribute and no <source> children, and should result in the element going to NETWORK_EMPTY
- Empty string "" is considered a valid src attribute and should be loaded (before it slipped through the cracks and the element would get jammed in NETWORK_LOADING)
Created attachment 41256 [details]
Round 3
Removed useless findMediaElement() line from video-src-empty.html
CCing the media master. Comment on attachment 41256 [details] Round 3 > + <p>Empty src attribute defined. Valid URL and video should error.</p> I think you meant to say "Invalid URL" r=me with this change. Thanks for catching this! Created attachment 41330 [details]
Round 4
Valid -> Invalid
Comment on attachment 41330 [details] Round 4 Clearing flags on attachment: 41330 Committed r49702: <http://trac.webkit.org/changeset/49702> All reviewed patches have been landed. Closing bug. |