Bug 30407

Summary:

HTML 5 media elements should set network state to NETWORK_EMPTY if they do not have a source

Product:

WebKit

Reporter:

Andrew Scherkus <scherkus>

Component:

Media

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eric.carlson, eric

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

OS X 10.5

Attachments:

Description	Flags
Round 1	none
Round 2	none
Round 3	eric.carlson: review+
Round 4	none

Andrew Scherkus

Reported 2009-10-15 14:36:00 PDT

Latest spec reads: "Otherwise the media element has neither a src attribute nor a source element child: set the networkState to NETWORK_EMPTY, and abort these steps; the synchronous section ends." http://www.whatwg.org/specs/web-apps/current-work/#concept-media-load-algorithm I also updated the comments to match the steps outlined in the spec.

Attachments
Round 1 (4.09 KB, patch) 2009-10-15 14:39 PDT, Andrew Scherkus	no flags	Details Formatted Diff Diff
Round 2 (6.86 KB, patch) 2009-10-15 17:59 PDT, Andrew Scherkus	no flags	Details Formatted Diff Diff
Round 3 (6.83 KB, patch) 2009-10-15 18:09 PDT, Andrew Scherkus	eric.carlson: review+	Details Formatted Diff Diff
Round 4 (6.83 KB, patch) 2009-10-16 14:37 PDT, Andrew Scherkus	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Andrew Scherkus

Comment 1 2009-10-15 14:39:18 PDT

Created attachment 41246 [details] Round 1

Andrew Scherkus

Comment 2 2009-10-15 15:36:55 PDT

Comment on attachment 41246 [details] Round 1 Digging around some more I found more bugs... I'll keep working on this patch.

Andrew Scherkus

Comment 3 2009-10-15 17:59:33 PDT

Created attachment 41255 [details] Round 2 Few things (as mentioned in the patch): - Having no source is defined as a null src attribute and no <source> children, and should result in the element going to NETWORK_EMPTY - Empty string "" is considered a valid src attribute and should be loaded (before it slipped through the cracks and the element would get jammed in NETWORK_LOADING)

Andrew Scherkus

Comment 4 2009-10-15 18:09:01 PDT

Created attachment 41256 [details] Round 3 Removed useless findMediaElement() line from video-src-empty.html

Eric Seidel (no email)

Comment 5 2009-10-16 13:30:58 PDT

CCing the media master.

Eric Carlson

Comment 6 2009-10-16 13:55:04 PDT

Comment on attachment 41256 [details] Round 3 > + <p>Empty src attribute defined. Valid URL and video should error.</p> I think you meant to say "Invalid URL" r=me with this change. Thanks for catching this!

Andrew Scherkus

Comment 7 2009-10-16 14:37:02 PDT

Created attachment 41330 [details] Round 4 Valid -> Invalid

WebKit Commit Bot

Comment 8 2009-10-16 15:03:50 PDT

Comment on attachment 41330 [details] Round 4 Clearing flags on attachment: 41330 Committed r49702: <http://trac.webkit.org/changeset/49702>

WebKit Commit Bot

Comment 9 2009-10-16 15:03:54 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.