Bug 303768
| Summary: | JSPromiseConstructor.cpp should include ObjectConstructor.h | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Vassili Bykov <v_bykov> |
| Component: | JavaScriptCore | Assignee: | Vassili Bykov <v_bykov> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Vassili Bykov
The recent PR for https://bugs.webkit.org/show_bug.cgi?id=303603 added code to JSPromiseConstructor.cpp that uses the function `constructEmptyObject()` defined in ObjectConstructor.h. That file is not explicitly included by JSPromiseConstructor.cpp, which causes spurious build failures if the .cpp file ends up in unified sources in a context that doesn't have the required definitions.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/166079243>
Vassili Bykov
Pull request: https://github.com/WebKit/WebKit/pull/55051
EWS
Committed 304109@main (ac6a27e1c512): <https://commits.webkit.org/304109@main>
Reviewed commits have been landed. Closing PR #55051 and removing active labels.