| Summary: | [Qt] Windowless Plugins : <input> cursor blinks even after transferring focus to plugin | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Girish Ramakrishnan <girish> | ||||||||||||||||||
| Component: | Plug-ins | Assignee: | Robert Hogan <robert> | ||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||
| Severity: | Normal | CC: | ademar, ariya.hidayat, dglazkov, hausmann, kenneth, kent.hansen, lists, robert, tonikitoo, webkit.review.bot, yael | ||||||||||||||||||
| Priority: | P2 | Keywords: | Qt, QtTriaged | ||||||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||||||||
| Hardware: | PC | ||||||||||||||||||||
| OS: | All | ||||||||||||||||||||
| Bug Depends on: | 20081 | ||||||||||||||||||||
| Bug Blocks: | 35962 | ||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||
Created attachment 41283 [details]
Work so far
Identifies one of the problems. The test works. But there is still a bad pointer somewhere (qgvlauncher still crashes).
Please(In reply to comment #1) > Created an attachment (id=41283) [details] > Work so far > > Identifies one of the problems. The test works. But there is still a bad > pointer somewhere (qgvlauncher still crashes). Err, ignore the patch. It was meant for 30354. (In reply to comment #2) > Please(In reply to comment #1) > > Created an attachment (id=41283) [details] [details] > > Work so far > > > > Identifies one of the problems. The test works. But there is still a bad > > pointer somewhere (qgvlauncher still crashes). > > Err, ignore the patch. It was meant for 30354. +void tst_QWebView::deletePageAfterView_data() +{ + QDir resourceDir(QDir::fromNativeSeparators(SRCDIR) + "../resources/"); + resourceDir.makeAbsolute(); + const QString flashPath = resourceDir.absoluteFilePath("test.swf"); + const QString flashUrl = QString("file://%1").arg(flashPath); girish, see trick used in patch for referencing a "resource" dir: https://bug-29248-attachments.webkit.org/attachment.cgi?id=40115 ihmo , it is cleaner We had the exact same problem (blinking cursor) for windowed plugins, as I remember fixing that :-) Maybe you can find the fix that I did back then. Changing platform to 'All'. Reproducible on Linux and Mac (Qt 4.6 git as of today) Created attachment 98408 [details]
Patch
Hi Simon, You OK with this? http://trac.webkit.org/changeset/42748 introduced the function - I think Qt and Gtk are its only users. Comment on attachment 98408 [details] Patch Attachment 98408 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/8934232 Created attachment 98413 [details]
Archive of layout-test-results from ec2-cr-linux-02
The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-02 Port: Chromium Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment on attachment 98408 [details] Patch Attachment 98408 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/8934237 Comment on attachment 98408 [details] Patch Attachment 98408 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/8936201 Comment on attachment 98408 [details]
Patch
Looks good in principle, but the bots show that there are build issues with WebKit2 and missing expected results for the other platforms. Landing the patch would cause build issues and bot-redness -> r-
Created attachment 98523 [details]
Patch
Comment on attachment 98523 [details] Patch Attachment 98523 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/8939457 Comment on attachment 98523 [details] Patch Attachment 98523 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/8931671 Created attachment 98544 [details]
Archive of layout-test-results from ec2-cr-linux-03
The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-03 Port: Chromium Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Created attachment 98586 [details]
Patch
Comment on attachment 98586 [details] Patch Attachment 98586 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/8936721 Created attachment 98587 [details]
Archive of layout-test-results from ec2-cr-linux-01
The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-01 Port: Chromium Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Created attachment 98594 [details]
Patch
Comment on attachment 98594 [details]
Patch
r=me. This needs to be landed manually as I'm sure mac results will be needed right after that.
Committed r90338: <http://trac.webkit.org/changeset/90338> Committed r90339: <http://trac.webkit.org/changeset/90339> Revision r90338 cherry-picked into qtwebkit-2.2 with commit bf3faac <http://gitorious.org/webkit/qtwebkit/commit/bf3faac> Revision r90339 cherry-picked into qtwebkit-2.2 with commit 4817c3f <http://gitorious.org/webkit/qtwebkit/commit/4817c3f> |
When the focus is transfered from an input element to plugin/flash in windowless mode, the cursor of the input box still blinks. Note that the focus does get transferred, keystrokes are sent to the plugin. <html> <body> <input/> <embed src="frog.swf" width="550" height="400" wmode="transparent"> </embed> </body> </html>